Why is lastResetTimerMsecs capped at 24 hours (resetting to 0 afterward), whereas bgpTimerUpMsec keeps incrementing without resetting?

[dev-amrit460]

show ip bgp neighbors 10.13.4.200 json
{
"10.13.4.200":{
"remoteAs":65500,
"localAs":65219,
"nbrExternalLink":true,
"localRole":"undefined",
"remoteRole":"undefined",
"hostname":"Unknown",
"bgpVersion":4,
"remoteRouterId":"10.13.4.200",
"localRouterId":"10.13.4.37",
"bgpState":"Established",
"bgpTimerUpMsec":617762000,
"bgpTimerUpString":"01w0d03h",
"bgpTimerUpEstablishedEpoch":1775457939,
"bgpTimerLastRead":1000,
"bgpTimerLastWrite":1000,
"bgpInUpdateElapsedTimeMsecs":9261000,
"bgpTimerConfiguredHoldTimeMsecs":3000,
"bgpTimerConfiguredKeepAliveIntervalMsecs":1000,
"bgpTimerHoldTimeMsecs":3000,
"bgpTimerKeepAliveIntervalMsecs":1000,
"bgpTcpMssConfigured":0,
"bgpTcpMssSynced":9174,
"extendedOptionalParametersLength":false,
"bgpTimerConfiguredConditionalAdvertisementsSec":60,
"neighborCapabilities":{
"4byteAs":"advertisedAndReceived",
"extendedMessage":"advertised",
"addPath":{
"ipv4Unicast":{
"rxAdvertised":true
},
"l2VpnEvpn":{
"rxAdvertisedAndReceived":true
}
},
"longLivedGracefulRestart":"advertised",
"routeRefresh":"advertisedAndReceived",
"enhancedRouteRefresh":"advertisedAndReceived",
"multiprotocolExtensions":{
"ipv4Unicast":{
"advertised":true
},
"l2VpnEvpn":{
"advertisedAndReceived":true
}
},
"hostName":{
"advHostName":"TEST-OXO-v01",
"advDomainName":"n/a"
},
"softwareVersion":{
},
"gracefulRestart":"advertisedAndReceived",
"gracefulRestartRemoteTimerMsecs":300000,
"addressFamiliesByPeer":"none"
},
"gracefulRestartInfo":{
"endOfRibSend":{
"l2VpnEvpn":true
},
"endOfRibRecv":{
"l2VpnEvpn":true
},
"localGrMode":"Helper*",
"remoteGrMode":"Helper",
"rBit":false,
"nBit":true,
"timers":{
"configuredRestartTimer":120,
"configuredLlgrStaleTime":0,
"receivedRestartTimer":300
},
"ipv4Unicast":{
"fBit":false,
"endOfRibStatus":{
"endOfRibSend":false,
"endOfRibSentAfterUpdate":false,
"endOfRibRecv":false
},
"timers":{
"stalePathTimer":360,
"llgrStaleTime":0
}
}
},
"messageStats":{
"depthInq":0,
"depthOutq":0,
"opensSent":3,
"opensRecv":3,
"notificationsSent":0,
"notificationsRecv":0,
"updatesSent":3754,
"updatesRecv":3431,
"keepalivesSent":1038874,
"keepalivesRecv":1219275,
"routeRefreshSent":0,
"routeRefreshRecv":0,
"capabilitySent":0,
"capabilityRecv":0,
"totalSent":1042631,
"totalRecv":1222709
},
"minBtwnAdvertisementRunsTimerMsecs":0,
"updateSource":"10.13.4.37",
"addressFamilyInfo":{
"ipv4Unicast":{
"commAttriSentToNbr":"extendedAndStandard",
"acceptedPrefixCounter":10
},
"l2VpnEvpn":{
"updateGroupId":3,
"subGroupId":3,
"packetQueueLength":0,
"unchangedNextHopPropogatedToNbr":true,
"commAttriSentToNbr":"extendedAndStandard",
"advertiseAllVnis":true,
"acceptedPrefixCounter":2087,
"sentPrefixCounter":2203
}
},
"connectionsEstablished":3,
"connectionsDropped":2,
"lastResetTimerMsecs":13025000,
"lastResetDueTo":"No AFI/SAFI activated for peer",
"lastResetCode":30,
"softwareVersion":"n/a",
"externalBgpNbrMaxHopsAway":255,
"hostLocal":"10.13.4.37",
"portLocal":4321,
"hostForeign":"10.13.4.200",
"portForeign":41421,
"nexthop":"10.13.4.37",
"nexthopGlobal":"::",
"nexthopLocal":"::",
"bgpConnection":"nonSharedNetwork",
"connectRetryTimer":120,
"estimatedRttInMsecs":2,
"readThread":"on",
"writeThread":"on"
}
}

• I noticed that lastResetTimerMsecs is computed using only hour/min/sec fields from struct tm, so it never exceeds 24 hours. Why doesn’t it include days like a full uptime counter (e.g., bgpTimerUpMsec)?

			 json_object_int_add(json_neigh, "lastResetTimerMsecs",
						 (tm.tm_sec * 1000)
							 + (tm.tm_min * 60000)
							 + (tm.tm_hour * 3600000));

			 time_t uptime;

			 uptime = monotime(NULL);
			 uptime -= p->uptime;
			 epoch_tbuf = time(NULL) - uptime;

			 json_object_int_add(json_neigh, "bgpTimerUpMsec",
						 uptime * 1000);

https://github.com/FRRouting/frr/blob/stable/10.0/bgpd/bgp_vty.c

[qlyoung]

Fixed in #21489