fix: resolve viewing inserter with filters set crashes game#329
Merged
ParadoxiKat merged 1 commit intoJun 21, 2025
Merged
Conversation
Factorio 2.0 may return filter names as strings. Viewing an inserter with filters set would crash due to an assertion when localising. Fixed by checking for string filters and looking up the prototype before localisation.
ParadoxiKat
force-pushed
the
InserterFilterFix
branch
from
70cc2f2 to
a130003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Factorio 2.0 may return filter names as strings. Viewing an inserter with filters set would crash due to an assertion when localising. Fixed by checking for string filters and looking up the prototype before localisation.