Skip to content

feat: add Managed Knowledge Base support to AWS Bedrock KB Retriever#6612

Open
PVidyadhar wants to merge 1 commit into
FlowiseAI:mainfrom
PVidyadhar:bmkb-managed-kb-support
Open

feat: add Managed Knowledge Base support to AWS Bedrock KB Retriever#6612
PVidyadhar wants to merge 1 commit into
FlowiseAI:mainfrom
PVidyadhar:bmkb-managed-kb-support

Conversation

@PVidyadhar

Copy link
Copy Markdown
  • Added Knowledge Base Type dropdown (MANAGED/VECTOR)
  • MANAGED path tries langchain first, falls back to direct Bedrock API
  • Direct API uses managedSearchConfiguration
  • Returns proper langchain Document objects via BaseRetriever subclass
  • Unit tests included
  • Added BEDROCK_MANAGED_KB.md design doc

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Amazon Bedrock Managed Knowledge Bases to the AWSBedrockKBRetriever node, allowing users to select between managed and traditional vector search. It implements a new ManagedKBRetriever class that supports agentic retrieval with query decomposition and automatic fallback mechanisms, adds corresponding unit tests, and provides documentation. The code review feedback suggests several key improvements: adding defensive nullish checks to prevent runtime errors in getSourceUri, optimizing performance by avoiding dynamic imports inside the query execution loop, and using the public getRelevantDocuments method instead of the protected _getRelevantDocuments to ensure LangChain lifecycle hooks and tracing are preserved.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@PVidyadhar PVidyadhar force-pushed the bmkb-managed-kb-support branch 4 times, most recently from 4047a53 to 8f10b40 Compare July 13, 2026 22:21
@PVidyadhar PVidyadhar marked this pull request as ready for review July 14, 2026 18:19
@PVidyadhar PVidyadhar force-pushed the bmkb-managed-kb-support branch 3 times, most recently from f3a46f2 to 2d5fa12 Compare July 16, 2026 02:22
- Added Knowledge Base Type dropdown (MANAGED/VECTOR)
- MANAGED path tries langchain first, falls back to direct Bedrock API
- Direct API uses managedSearchConfiguration
- Returns proper langchain Document objects via BaseRetriever subclass
- Unit tests included
- Added BEDROCK_MANAGED_KB.md design doc
@PVidyadhar PVidyadhar force-pushed the bmkb-managed-kb-support branch from 2d5fa12 to 7a2c932 Compare July 16, 2026 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant