bug fixes

Author: ZacharyBer

.github/workflows/auto-bump-minor.yml

@@ -44,8 +44,10 @@ jobs:
           # exits 0 without committing when the PR didn't touch any board or
           # common/ path — in that case there's nothing new on HEAD to push.
           if [ "$(git rev-list --count origin/main..HEAD)" -gt 0 ]; then
-            git push origin main
-            git push origin --tags
+            # --atomic makes the branch update and tag push a single transaction:
+            # if the server rejects either, neither is applied, so we never end
+            # up with a bump commit on main without its matching tag.
+            git push --atomic origin main --tags
           else
             echo "No version bump commit produced; nothing to push."
           fi

BMS/Core/User/Src/FEB_ADBMS6830B.c

@@ -13,6 +13,7 @@
 #include "FEB_ADBMS6830B_Driver.h"
 
 #include <float.h>
+#include <math.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include "stm32f4xx_hal.h"
@@ -362,6 +363,13 @@ static void compute_pack_temp_stats(void)
   }
   else
   {
+    // All sensor readings were invalid. Publish NaN so consumers can detect
+    // the condition (NaN propagates through comparisons as false), and raise
+    // the same diagnostic that validate_temps() uses for chronically-low reads.
+    FEB_ACC.pack_min_temp = NAN;
+    FEB_ACC.pack_max_temp = NAN;
+    FEB_ACC.average_pack_temp = NAN;
+    FEB_ADBMS_Update_Error_Type(ERROR_TYPE_LOW_TEMP_READS);
     DEBUG_TEMP_PRINT("Pack stats: no valid readings");
   }
 }
@@ -737,6 +745,19 @@ void FEB_Cell_Balance_Process()
 
 bool FEB_Cell_Balancing_Status(void)
 {
+  // The per-cell loop used to index temp_sensor_readings by cell index, which
+  // only covered FEB_NUM_CELLS_PER_BANK (14) of the FEB_NUM_TEMP_SENSORS (42)
+  // sensors. Use the pack-wide max computed by compute_pack_temp_stats() so
+  // every MUX output is considered. NaN (all-invalid readings) fails the
+  // comparison and stops balancing — the safe default when we have no thermal
+  // telemetry.
+  const float max_temp_dC = FEB_ADBMS_GET_ACC_MAX_Temp() * 10.0f;
+  if (!(max_temp_dC < FEB_CONFIG_CELL_SOFT_MAX_TEMP_dC))
+  {
+    LOG_W(TAG_BALANCE, "Temp limit: pack max=%.1fC, stopping", max_temp_dC / 10.0f);
+    return false;
+  }
+
   float min_v = FLT_MAX;
   float max_v = FLT_MIN;
 
@@ -745,13 +766,6 @@ bool FEB_Cell_Balancing_Status(void)
     for (size_t j = 0; j < FEB_NUM_CELLS_PER_BANK; ++j)
     {
       const float voltage = FEB_ADBMS_GET_Cell_Voltage(i, j) * 1000.0f;
-      const float temp = FEB_ADBMS_GET_Cell_Temperature(i, j) * 10.0f;
-
-      if (temp >= FEB_CONFIG_CELL_SOFT_MAX_TEMP_dC)
-      {
-        LOG_W(TAG_BALANCE, "Temp limit: Bank%zu Cell%zu = %.1fC, stopping", i, j, temp / 10.0f);
-        return false;
-      }
 
       if (voltage < 0)
       {

BMS/Core/User/Src/FEB_ADBMS6830B_Driver.c

@@ -637,18 +637,41 @@ uint8_t ADBMS6830B_rdaux(uint8_t total_ic, // The number of ICs in the system
     return 1;
   }
 
+  // Match rdcv/rdsv/rdsid: ensure the daisy chain is awake before the first
+  // command or the leading frames can be dropped on a sleeping chain.
+  wakeup_sleep(total_ic);
+
   // RDAUXA: GPIO1-3 -> a_codes[0..2]
   transmitCMDR(RDAUXA, cell_data, NUM_RX_BYT * total_ic);
   for (int i = 0; i < total_ic; i++)
   {
-    memcpy(&ic[i].aux.a_codes[0], cell_data + i * NUM_RX_BYT, 6);
+    uint8_t *ic_data = cell_data + i * NUM_RX_BYT;
+    memcpy(&ic[i].aux.a_codes[0], ic_data, 6);
+
+    // PEC is big-endian: ic_data[6] is MSB, ic_data[7] is LSB (same layout
+    // as rdcfga/rdcfgb/rdsid). Record per-IC match so downstream consumers
+    // like check_and_report_pec_errors() can drive redundancy failover.
+    uint16_t calc_pec = Pec10_calc(false, 6, ic_data);
+    uint16_t rx_pec = ((uint16_t)ic_data[6] << 8) | ic_data[7];
+    bool mismatch = (calc_pec != rx_pec);
+    ic[i].aux.pec_match[0] = mismatch ? 1 : 0;
+    if (mismatch)
+      pec_error++;
   }
 
   // RDAUXB: GPIO4-6 -> a_codes[3..5]
   transmitCMDR(RDAUXB, cell_data, NUM_RX_BYT * total_ic);
   for (int i = 0; i < total_ic; i++)
   {
-    memcpy(&ic[i].aux.a_codes[3], cell_data + i * NUM_RX_BYT, 6);
+    uint8_t *ic_data = cell_data + i * NUM_RX_BYT;
+    memcpy(&ic[i].aux.a_codes[3], ic_data, 6);
+
+    uint16_t calc_pec = Pec10_calc(false, 6, ic_data);
+    uint16_t rx_pec = ((uint16_t)ic_data[6] << 8) | ic_data[7];
+    bool mismatch = (calc_pec != rx_pec);
+    ic[i].aux.pec_match[1] = mismatch ? 1 : 0;
+    if (mismatch)
+      pec_error++;
   }
 
   vPortFree(cell_data);

BMS/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

DART/VERSION

@@ -1 +1 @@
-1.0.3
+1.0.4

DASH/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

DCU/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

LVPDB/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

PCU/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2

Sensor_Nodes/VERSION

@@ -1 +1 @@
-1.0.1
+1.0.2