Skip to content

Commit 897188c

Browse files
ZacharyBerZacharyBer
committed
DASH: drop internal pull-up on I2C1 (PB8/PB9); use external pull-ups
The I2C1 bus (IO expander + TPS power monitor) has external pull-ups on the PCB. The MCU internal pull-ups on PB8/PB9 ran in parallel with them, lowering the effective bus resistance. Disable the internal pull-ups via the .ioc (GPIO_Pu=GPIO_NOPULL) and rely on the external resistors. Regen also corrected a stale functionlistsort entry (MX_CAN1 -> MX_CAN2) to match the board's actual CAN2 usage; no generated code changed from it.
1 parent ab5fcd0 commit 897188c

5 files changed

Lines changed: 18 additions & 18 deletions

File tree

‎.cubemx-manifest.json‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"boards": {
55
"BMS": {
66
"ioc_checksum": "80286fd43261cea1eb2d21ef56ffbe570965fc09d3575772c6ddfccd9be45a6d",
7-
"generated_at": "2026-06-16T08:51:25Z",
7+
"generated_at": "2026-06-17T06:48:29Z",
88
"files": {
99
"Core/Inc/FreeRTOSConfig.h": "363755b7a21dd5a790f0bafbfd68f00abe141fd8691720b3604bc84b7dbaa81b",
1010
"Core/Inc/adc.h": "0ac97025a4065f07b7b65a906bd0c45ea800215434ed43c287c1685507f3f612",
@@ -74,8 +74,8 @@
7474
}
7575
},
7676
"DASH": {
77-
"ioc_checksum": "86f30e3c35351fc2b7667a78c5d2a7a46b92ffde5245a73b16097aec5292bf77",
78-
"generated_at": "2026-06-16T08:51:27Z",
77+
"ioc_checksum": "e3dbb4fb3491fda8887551d897a0f8e1d4729295328e8c775dadb9370d524c30",
78+
"generated_at": "2026-06-17T06:48:31Z",
7979
"files": {
8080
"Core/Inc/FreeRTOSConfig.h": "692168cbc9c915133ce3f329cec850c5372c1759ec0412ced61fc14741de14be",
8181
"Core/Inc/can.h": "01d68e4cc9445e207e6ade2905aceff837c3d5ffa3de21c3e55ba908d706531c",
@@ -103,7 +103,7 @@
103103
"Core/Src/fmc.c": "dbe73a64fbad9a97f91d48840259f847c3d3379594eed35927573a000434870f",
104104
"Core/Src/freertos.c": "11f07314633aa9a27dbd5ea834c37ad753f786b85dca3269d63950349697bd87",
105105
"Core/Src/gpio.c": "19994dd9dee2dbb016c0904751dc4e1fb1987c18a5b01342610763afe44e7f4c",
106-
"Core/Src/i2c.c": "79ed3167015be9d06d2f828464d7ce72f3372b4d63c3ed15f3a32c6f66427381",
106+
"Core/Src/i2c.c": "b1bbdfe4520ae58656eb1e400bcdd668f4631951a57d9cb7235d70d4b808c551",
107107
"Core/Src/ltdc.c": "448426cef3f409b2b6b9389fa778ecde8f82bb45c46cc9315b72b363c2902d0a",
108108
"Core/Src/main.c": "6ed5366caf26735f8dcd26ddf1a89b51bc5ba4737c83aad7a1900ef2b24c9a3b",
109109
"Core/Src/quadspi.c": "ff4a8b7e31794e4bfdeb2c0731b4f140c6c11179bbe356b32f7125f8cfc910a3",
@@ -177,7 +177,7 @@
177177
},
178178
"DART": {
179179
"ioc_checksum": "5e40a62867a13bf2ccbc21a8343b896b2979b658d024cb6721e46e05b32b5a45",
180-
"generated_at": "2026-06-16T08:51:28Z",
180+
"generated_at": "2026-06-17T06:48:31Z",
181181
"files": {
182182
"Core/Inc/can.h": "8bb6621564cd436d9b9697bc86bc4c6f6ae0492b84673344dfa5a3a2d0ee06cb",
183183
"Core/Inc/dma.h": "7cf6f7450a29d26303cbba5a3ca8c6cb24a02635d6a5ba4d05141fdfc75c4c49",
@@ -203,7 +203,7 @@
203203
},
204204
"DCU": {
205205
"ioc_checksum": "3ca0c8e6d3c37e459605b21b9193ba2cfe5a96315c2aa0cf6f560a585e03e01f",
206-
"generated_at": "2026-06-16T08:51:30Z",
206+
"generated_at": "2026-06-17T06:48:33Z",
207207
"files": {
208208
"Core/Inc/FreeRTOSConfig.h": "f664caa84f355ae18d9faf3f04e5f62d8c95d07210511fb284854ae5a426e17e",
209209
"Core/Inc/can.h": "98925d7f4010f054e17d240116244377377c15248a5413a09ff811cdc23084e5",
@@ -289,7 +289,7 @@
289289
},
290290
"DCU_Receiver": {
291291
"ioc_checksum": "ee791e4c6161c1471ae52fb81c2b892a3aab78da6b64e6bf4180ca8c0d88bf66",
292-
"generated_at": "2026-06-16T08:51:31Z",
292+
"generated_at": "2026-06-17T06:48:34Z",
293293
"files": {
294294
"Core/Inc/FreeRTOSConfig.h": "6b4080b1f5aedb3793f3fb347d7bc61907a53df5104d805995aa77085aaafcd4",
295295
"Core/Inc/dma.h": "7cf6f7450a29d26303cbba5a3ca8c6cb24a02635d6a5ba4d05141fdfc75c4c49",
@@ -356,7 +356,7 @@
356356
},
357357
"LVPDB": {
358358
"ioc_checksum": "aad83d2888e50c4498ca882150e6cc94c6266554b55da81220b3a142c5b5e4b2",
359-
"generated_at": "2026-06-16T08:51:31Z",
359+
"generated_at": "2026-06-17T06:48:35Z",
360360
"files": {
361361
"Core/Inc/can.h": "17611aeff90b90e352bc2ace2749644663492ecb10c71539567ef9b1441fd5d9",
362362
"Core/Inc/dma.h": "7cf6f7450a29d26303cbba5a3ca8c6cb24a02635d6a5ba4d05141fdfc75c4c49",
@@ -384,7 +384,7 @@
384384
},
385385
"PCU": {
386386
"ioc_checksum": "3eaf91e0bfa3eca7f8f45868c51a0ac1dcb92b96efaedca982684c948468503b",
387-
"generated_at": "2026-06-16T08:51:32Z",
387+
"generated_at": "2026-06-17T06:48:36Z",
388388
"files": {
389389
"Core/Inc/adc.h": "e36acfe1b822eff1de7e9f93073b8da32c94dd5b09484b716e190c6aa63eb3d0",
390390
"Core/Inc/can.h": "98925d7f4010f054e17d240116244377377c15248a5413a09ff811cdc23084e5",
@@ -414,7 +414,7 @@
414414
},
415415
"Sensor_Nodes": {
416416
"ioc_checksum": "92d075b8d175250a76dee123ca59955032f2ebe8519ffb49e998bb810b3701f2",
417-
"generated_at": "2026-06-16T08:51:33Z",
417+
"generated_at": "2026-06-17T06:48:36Z",
418418
"files": {
419419
"Core/Inc/adc.h": "0ac97025a4065f07b7b65a906bd0c45ea800215434ed43c287c1685507f3f612",
420420
"Core/Inc/can.h": "98925d7f4010f054e17d240116244377377c15248a5413a09ff811cdc23084e5",
@@ -444,7 +444,7 @@
444444
},
445445
"UART": {
446446
"ioc_checksum": "9ff281c674a516d9870dbee5d60587351e97884ecd27127e2d1464987bf16a17",
447-
"generated_at": "2026-06-16T08:51:34Z",
447+
"generated_at": "2026-06-17T06:48:37Z",
448448
"files": {
449449
"Core/Inc/FreeRTOSConfig.h": "2a0e6022391d5ec198a77021ec3bf284583e245f9ce20c420fb7608f638330d6",
450450
"Core/Inc/dma.h": "7cf6f7450a29d26303cbba5a3ca8c6cb24a02635d6a5ba4d05141fdfc75c4c49",
@@ -504,7 +504,7 @@
504504
},
505505
"UART_TEST": {
506506
"ioc_checksum": "06c9618835096e44e3f73cd158bbc2e3fcf76e65dc9a29db68fe607180843efd",
507-
"generated_at": "2026-06-16T08:51:35Z",
507+
"generated_at": "2026-06-17T06:48:39Z",
508508
"files": {
509509
"Core/Inc/FreeRTOSConfig.h": "773dad076864ff18d5d85603d348d4931d29dde9925486e58f95a97ac98b8404",
510510
"Core/Inc/app_freertos.h": "6229601c2ebf192d40ceef377f3c1785571eaf6407f10bc87be5b06357dd3515",

‎DASH/Core/Src/i2c.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ void HAL_I2C_MspInit(I2C_HandleTypeDef* i2cHandle)
103103
*/
104104
GPIO_InitStruct.Pin = I2C1_SCL_Pin|I2C1_SDA_Pin;
105105
GPIO_InitStruct.Mode = GPIO_MODE_AF_OD;
106-
GPIO_InitStruct.Pull = GPIO_PULLUP;
106+
GPIO_InitStruct.Pull = GPIO_NOPULL;
107107
GPIO_InitStruct.Speed = GPIO_SPEED_FREQ_VERY_HIGH;
108108
GPIO_InitStruct.Alternate = GPIO_AF4_I2C1;
109109
HAL_GPIO_Init(GPIOB, &GPIO_InitStruct);

‎DASH/DASH.ioc‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -401,15 +401,15 @@ PB7.Signal=GPXTI7
401401
PB8.GPIOParameters=GPIO_Speed,GPIO_Label,GPIO_Pu,GPIO_Mode
402402
PB8.GPIO_Label=I2C1_SCL
403403
PB8.GPIO_Mode=GPIO_MODE_AF_OD
404-
PB8.GPIO_Pu=GPIO_PULLUP
404+
PB8.GPIO_Pu=GPIO_NOPULL
405405
PB8.GPIO_Speed=GPIO_SPEED_FREQ_VERY_HIGH
406406
PB8.Locked=true
407407
PB8.Mode=I2C
408408
PB8.Signal=I2C1_SCL
409409
PB9.GPIOParameters=GPIO_Speed,GPIO_Label,GPIO_Pu,GPIO_Mode
410410
PB9.GPIO_Label=I2C1_SDA
411411
PB9.GPIO_Mode=GPIO_MODE_AF_OD
412-
PB9.GPIO_Pu=GPIO_PULLUP
412+
PB9.GPIO_Pu=GPIO_NOPULL
413413
PB9.GPIO_Speed=GPIO_SPEED_FREQ_VERY_HIGH
414414
PB9.Locked=true
415415
PB9.Mode=I2C
@@ -1063,7 +1063,7 @@ ProjectManager.ToolChainLocation=
10631063
ProjectManager.UAScriptAfterPath=
10641064
ProjectManager.UAScriptBeforePath=
10651065
ProjectManager.UnderRoot=false
1066-
ProjectManager.functionlistsort=1-SystemClock_Config-RCC-false-HAL-false,2-MX_GPIO_Init-GPIO-false-HAL-true,3-MX_DMA_Init-DMA-false-HAL-true,4-MX_CAN1_Init-CAN1-false-HAL-true,4-MX_CRC_Init-CRC-false-HAL-true,5-MX_DMA2D_Init-DMA2D-false-HAL-true,6-MX_DSIHOST_DSI_Init-DSIHOST-false-HAL-true,7-MX_FMC_Init-FMC-false-HAL-true,8-MX_I2C1_Init-I2C1-false-HAL-true,9-MX_I2C2_Init-I2C2-false-HAL-true,10-MX_LTDC_Init-LTDC-false-HAL-true,11-MX_QUADSPI_Init-QUADSPI-false-HAL-true,12-MX_SAI1_Init-SAI1-false-HAL-true,13-MX_SDIO_SD_Init-SDIO-false-HAL-true,14-MX_TIM1_Init-TIM1-false-HAL-true,15-MX_USART3_UART_Init-USART3-false-HAL-true,16-MX_USART6_UART_Init-USART6-false-HAL-true,17-MX_FATFS_Init-FATFS-false-HAL-false
1066+
ProjectManager.functionlistsort=1-SystemClock_Config-RCC-false-HAL-false,2-MX_GPIO_Init-GPIO-false-HAL-true,3-MX_DMA_Init-DMA-false-HAL-true,4-MX_CRC_Init-CRC-false-HAL-true,5-MX_DMA2D_Init-DMA2D-false-HAL-true,6-MX_DSIHOST_DSI_Init-DSIHOST-false-HAL-true,7-MX_FMC_Init-FMC-false-HAL-true,8-MX_I2C1_Init-I2C1-false-HAL-true,9-MX_I2C2_Init-I2C2-false-HAL-true,10-MX_LTDC_Init-LTDC-false-HAL-true,11-MX_QUADSPI_Init-QUADSPI-false-HAL-true,12-MX_SAI1_Init-SAI1-false-HAL-true,13-MX_SDIO_SD_Init-SDIO-false-HAL-true,14-MX_TIM1_Init-TIM1-false-HAL-true,15-MX_USART3_UART_Init-USART3-false-HAL-true,16-MX_USART6_UART_Init-USART6-false-HAL-true,17-MX_FATFS_Init-FATFS-false-HAL-false,18-MX_CAN2_Init-CAN2-false-HAL-true
10671067
QUADSPI.ChipSelectHighTime=QSPI_CS_HIGH_TIME_5_CYCLE
10681068
QUADSPI.ClockPrescaler=1
10691069
QUADSPI.FifoThreshold=1

‎DASH/VERSION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.8.0
1+
1.8.1

‎VERSION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.9.4
1+
1.9.5

0 commit comments

Comments
 (0)