fix: resolve bugs in CI workflow and git hooks

- Remove unused esbuild build step from publish workflow (missing dep)
- Add prepare script to auto-configure git hooks path
- Fix commit-msg hook permissions (was not executable)
- Remove main-branch gate so hooks run on all branches
- Add package.json for hooks to fix CommonJS/ESM conflict
- Add set -euo pipefail for proper error handling in pre-commit
- Fix silent git error suppression in shell scripts
- Fix return detection regex to handle newlines before value
- Add workflow_dispatch, npm cache, and concurrency to workflow

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: Brian

.github/workflows/publish.yml

@@ -3,6 +3,11 @@ name: Publish to npm with Provenance
 on:
   release:
     types: [published]
+  workflow_dispatch:  # Allow manual triggers for hotfixes
+
+concurrency:
+  group: publish-${{ github.ref }}
+  cancel-in-progress: false  # Don't cancel in-progress publishes
 
 jobs:
   publish:
@@ -19,16 +24,14 @@ jobs:
         with:
           node-version: '20'
           registry-url: 'https://registry.npmjs.org'
+          cache: 'npm'  # Cache npm dependencies for faster builds
 
       - name: Install dependencies
         run: npm ci
 
       - name: Run tests
         run: npm test
 
-      - name: Build browser bundle
-        run: npx esbuild index.js --bundle --minify --sourcemap --outfile=dist/bri.js
-
       - name: Publish to npm with provenance
         run: npm publish --provenance --access public
         env:

.hooks/commit-msg

@@ -1,15 +1,9 @@
 #!/usr/bin/env bash
+set -euo pipefail
 # .hooks/pre-commit - Pre-commit validation orchestrator for BRI 🐺
 # This script runs all check scripts in .hooks/pre-commit.d/
 # Each check script must exit 0 on success, non-zero on failure.
 
-# Only run on main branch
-CURRENT_BRANCH=$(git rev-parse --abbrev-ref HEAD)
-if [ "$CURRENT_BRANCH" != "main" ]; then
-    echo "🦍 Skipping pre-commit checks on branch: $CURRENT_BRANCH (checks only run on main)"
-    exit 0
-fi
-
 HOOKS_DIR="$(cd "$(dirname "$0")" && pwd)"
 CHECKS_DIR="$HOOKS_DIR/pre-commit.d"
 

.hooks/pre-commit

@@ -85,7 +85,10 @@ check_file_documented() {
 }
 
 # Get list of staged files (added or modified)
-STAGED_FILES=$(git diff --cached --name-only --diff-filter=AM 2>/dev/null || true)
+if ! STAGED_FILES=$(git diff --cached --name-only --diff-filter=AM 2>&1); then
+    echo "❌ Failed to get staged files from git"
+    exit 1
+fi
 
 # Exit early if no staged files
 if [ -z "$STAGED_FILES" ]; then
@@ -105,7 +108,7 @@ for file in $STAGED_FILES; do
     dir=$(dirname "$file")
     while [ "$dir" != "." ] && [ "$dir" != "/" ]; do
         # Check if this directory is being newly created (not in HEAD)
-        if ! git ls-tree -d HEAD "$dir" &>/dev/null 2>&1; then
+        if ! git ls-tree -d HEAD "$dir" >/dev/null 2>&1; then
             # Add to array if not already present
             if ! array_contains "$dir" "${NEW_DIRS[@]}"; then
                 NEW_DIRS+=("$dir")

.hooks/pre-commit.d/check-docs.sh

@@ -22,7 +22,11 @@ if [ ! -f "$VALIDATOR" ]; then
 fi
 
 # Get list of staged JS files (added or modified)
-STAGED_FILES=$(git diff --cached --name-only --diff-filter=AM 2>/dev/null | grep '\.js$' || true)
+if ! ALL_STAGED=$(git diff --cached --name-only --diff-filter=AM 2>&1); then
+    echo "❌ Failed to get staged files from git"
+    exit 1
+fi
+STAGED_FILES=$(echo "$ALL_STAGED" | grep '\.js$' || true)
 
 # Exit early if no JS files staged
 if [ -z "$STAGED_FILES" ]; then

.hooks/pre-commit.d/check-jsdoc.sh

@@ -18,7 +18,8 @@ function hasReturnValue(body) {
     .replace(/`(?:[^`\\]|\\.)*`/g, '""');
 
   // Check for return with a value (not just "return;" or "return}")
-  return /return\s+[^;\s}]/.test(cleaned);
+  // Handles: return value; return\n  value; return {obj}; return [arr];
+  return /return[\s\n]+[^;\s}]/.test(cleaned);
 }
 
 /**

.hooks/pre-commit.d/jsdoc/utils.js

@@ -0,0 +1,3 @@
+{
+  "type": "commonjs"
+}

.hooks/pre-commit.d/package.json

@@ -37,6 +37,10 @@ array_contains() {
 }
 
 # Get list of staged files (added or modified)
+# Returns 1 if git command fails, 0 otherwise (even if no files)
 get_staged_files() {
-    git diff --cached --name-only --diff-filter=AM 2>/dev/null || true
+    if ! git diff --cached --name-only --diff-filter=AM 2>&1; then
+        return 1
+    fi
+    return 0
 }

.hooks/pre-commit.d/utils.sh

@@ -14,7 +14,8 @@
   },
   "scripts": {
     "test": "node --experimental-vm-modules node_modules/jest/bin/jest.js",
-    "test:coverage": "node --experimental-vm-modules node_modules/jest/bin/jest.js --coverage"
+    "test:coverage": "node --experimental-vm-modules node_modules/jest/bin/jest.js --coverage",
+    "prepare": "git config core.hooksPath .hooks"
   },
   "devDependencies": {
     "jest": "^29.7.0"