This text is not a task.
- This is a task ~3d #feat @john 2020-03-20
- This is a task with a subtask ~1d #bug @jane
- And it has a subtask!
- revisit some of the
check_functions. I think the default approach should be the aim of thecheck_()functions is only to verify the input is as expected. Currently these functions do a lot more:-
check_col_plan_dots() -
check_span_structure_dots()
-
- revisit
is_valid_()functionality- the constructor should always produce a valid object
- functions should check their inputs. If the function is not user facing, then it should report the error / condition from the calling function. For example,
apply_tfrmt()should have acall = rlang::caller_env()argument. - all user-facing functions should check all their inputs before doing any work.
- for example,
big_n_structure()should checkparam_val
- for example,
- all S3 classes introduced by {tfrmt} should have matching
is_<class>()andcheck_<class>()functions.
- prefer
expect_equal()toexpect_identical()(contrary to {lintr}). Follow Hadley's advice: "Numerical precision can also vary across platforms, so useexpect_equal()unless you have a specific reason for usingexpect_identical()." @dragosmg
- use namespaced calls @dragosmg
-
This task has been declined(declined)