Commit d5cf274
authored
Dead code removal 2 (#78)
* fix: remove dead code from kit/ and InstanceDialog
Remove unused code identified by deep scan:
- Delete kit/core/func.dart (Fns.throttle unused)
- Delete kit/core/build.dart (BuildMode unused after dprint removal)
- Delete kit/core/ext/string.dart (StringX.launchUrl unused)
- Remove dprint/lprint and unused Loggers.root/store/route/app from logger.dart
- Remove nullOr() extension and nvn() function from obj.dart
- Remove RNodeX.listen(), ValBuilder, listenVal(), EmptyListenable, RNodes from rnode.dart
- Remove WindowFrameConfig.setShowCaption() (never called)
- Remove unused platform constants: isAndroid, isIOS, isWeb, isMobile
- Remove ~20 unused UIs style constants (keep textGrey, textRed, text15, placeholder, height13)
- Remove InstanceDialog.onSave parameter and dead branch in _submit
- Clean up barrel exports in kit.dart
* perf: optimize sort comparator and fix empty setState callbacks
Performance:
- Extract _statusOrder Map to static const (avoids allocation per comparison)
- Extract _compareIgnoreCase helper for case-insensitive sort
Code quality:
- Move _pruneSelection mutation inside setState callback
- Move peers fetch state mutations inside setState in task_details_dialog
- Remove no-op empty setState in instance_dialog host/port onChange handlers
* fix: peers fetch setState after dispose and isLoadingPeers leak
- Replace early return on instance==null with local error variable
- Move setState into finally block with context.mounted guard
- Use local peersResult/peersErrorLocal to avoid duplicated setState1 parent 1a43f8f commit d5cf274
14 files changed
Lines changed: 48 additions & 246 deletions
File tree
- lib
- kit
- core
- ext
- res
- widgets
- pages
- download_page
- components
- instance_page/components
- services
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | 8 | | |
11 | 9 | | |
12 | | - | |
13 | | - | |
This file was deleted.
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | 3 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | 4 | | |
14 | 5 | | |
15 | 6 | | |
| |||
35 | 26 | | |
36 | 27 | | |
37 | 28 | | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | 41 | | |
44 | 42 | | |
45 | 43 | | |
46 | | - | |
47 | | - | |
48 | 44 | | |
49 | 45 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | 53 | | |
60 | 54 | | |
61 | 55 | | |
| |||
74 | 68 | | |
75 | 69 | | |
76 | 70 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
111 | | - | |
112 | | - | |
113 | | - | |
114 | | - | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
4 | 3 | | |
5 | 4 | | |
6 | | - | |
7 | 5 | | |
8 | | - | |
9 | 6 | | |
10 | 7 | | |
11 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
6 | | - | |
7 | | - | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | | - | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | 4 | | |
23 | | - | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | 5 | | |
30 | 6 | | |
31 | 7 | | |
32 | 8 | | |
33 | | - | |
34 | 9 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | 10 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
9 | | - | |
10 | | - | |
11 | | - | |
12 | | - | |
13 | | - | |
14 | | - | |
| 8 | + | |
15 | 9 | | |
16 | 10 | | |
17 | 11 | | |
| |||
0 commit comments