Commit 97bbf8c
committed
Fail loudly on graphs beyond the 32-bit node range
DuckDBSelfHits() coerced nnode (and supplied node ids) with as.integer(),
which silently produced NA above 2^31 and corrupted graph reconstruction at
read time. It now errors with an explicit message when nnode or a node id
exceeds the 32-bit integer range; graphs with more than ~2.1e9 nodes are not
yet supported (the node-id slots are 32-bit). Behavior within the 32-bit range
is unchanged.
This closes the read-side half of the > 2^31 hardening: the write path can now
emit a > 2^31-edge graph index (BiocDuckDB writeParquet index_max), so a huge
node count must fail at construction rather than silently become NA.
Bump version to 0.99.4; update NEWS.1 parent ad25e5e commit 97bbf8c
4 files changed
Lines changed: 32 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
1 | 10 | | |
2 | 11 | | |
3 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
448 | 448 | | |
449 | 449 | | |
450 | 450 | | |
| 451 | + | |
| 452 | + | |
| 453 | + | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
451 | 459 | | |
452 | 460 | | |
453 | 461 | | |
| |||
457 | 465 | | |
458 | 466 | | |
459 | 467 | | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
| 471 | + | |
460 | 472 | | |
461 | 473 | | |
462 | 474 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
351 | 351 | | |
352 | 352 | | |
353 | 353 | | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
0 commit comments