Skip to content

Commit cafc313

Browse files
committed
fix(DuckDBDataFrame): declare x formal in table() methods for Bioc-devel x-dispatch generic (0.99.1)
1 parent 0059da9 commit cafc313

4 files changed

Lines changed: 20 additions & 8 deletions

File tree

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
Package: DuckDBDataFrame
2-
Version: 0.99.00
3-
Date: 2026-07-19
2+
Version: 0.99.1
3+
Date: 2026-07-21
44
Title: DuckDB-Backed DataFrame and Table Structures
55
Description:
66
Provides DuckDB-backed implementations of core tabular data structures

NEWS.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,17 @@
1+
# DuckDBDataFrame 0.99.1
2+
3+
## Bug fixes
4+
5+
- The `table()` methods for `DuckDBTable` and `DuckDBColumn` now declare `x` as
6+
a formal argument (`function(x, ...)`), conforming to the `table` generic in
7+
Bioconductor-devel `BiocGenerics`, which dispatches on `x`
8+
(`setGeneric("table", signature = "x")`) rather than on `...`. Under the
9+
previous `function(...)` definition the package failed to install on
10+
Bioc-devel with a `conformMethod` error ("formal arguments ... omitted in the
11+
method definition cannot be in the signature"). Behavior is unchanged, and the
12+
new signature also conforms against the `...`-dispatch generic in the current
13+
Bioconductor release.
14+
115
# DuckDBDataFrame 0.9.29
216

317
## New features

R/DuckDBColumn-utils.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -524,8 +524,8 @@ setMethod("%in%", c(x = "DuckDBColumn", table = "ANY"), function(x, table) {
524524
})
525525

526526
#' @export
527-
setMethod("table", "DuckDBColumn", function(...) {
528-
callGeneric(cbind.DuckDBDataFrame(...))
527+
setMethod("table", "DuckDBColumn", function(x, ...) {
528+
callGeneric(cbind.DuckDBDataFrame(x, ...))
529529
})
530530

531531
### - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

R/DuckDBTable-utils.R

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -884,12 +884,10 @@ setMethod("%in%", c(x = "DuckDBTable", table = "ANY"), function(x, table) {
884884
#' @export
885885
#' @importFrom dplyr group_by n summarize
886886
#' @importFrom stats setNames
887-
setMethod("table", "DuckDBTable", function(...) {
888-
args <- list(...)
889-
if (length(args) != 1L) {
887+
setMethod("table", "DuckDBTable", function(x, ...) {
888+
if (...length() != 0L) {
890889
stop("\"table\" method for DuckDB data can only take one input object")
891890
}
892-
x <- args[[1L]]
893891
conn <- tblconn(x, select = FALSE)
894892
groups <- as.list(x@datacols)
895893
counts <- as.data.frame(summarize(group_by(conn, !!!groups), count = n(), .groups = "drop"))

0 commit comments

Comments
 (0)