Further improve finishing process

Author: maksymiuks

DESCRIPTION

@@ -1,6 +1,6 @@
 Package: checked
 Title: Systematically Run R CMD Checks
-Version: 0.5.1.9002
+Version: 0.5.1.9003
 Authors@R:
     c(
       person(

NEWS.md

@@ -10,6 +10,8 @@
 * Finish check process even if checks seem incomplete but 3 or mire minutes have
   passed since the process ended to avoid infinite loops.
 
+* Further improvements to the check process finisher.
+
 # checked 0.5.1
 
 * Export STATUS vector to make external statuses analysis easier.

R/check_process.R

@@ -71,17 +71,18 @@ check_process <- R6::R6Class(
       if (!self$is_alive()) callback(self)
     },
     finish = function() {
-      # self$checks active binding calls poll_output so there is not need
-      # to call it explicitly
+      # Make sure results are polled
+      self$poll_output()
       checks <- self$checks
       # In some cases, check subprocess might suffer from a race condition, when
       # process itself finished, but the final results of the last subcheck
       # are not yet available to parse. Therefore we allow the process to
       # finalize only if the last subcheck has reported status. However
       # if we stuck in this state for longer than 3 minutes we should
       # try to finish anyway, to prevent possible infinite loops.
+      time_finished <- self$get_time_finish() %||% Sys.time()
       if (checks[length(checks)] != "" ||
-          (Sys.time() - self$get_time_finish() >= as.difftime(3, units = "mins"))) {
+          ((Sys.time() - time_finished) >= as.difftime(3, units = "mins"))) {
         self$save_results()
         private$cache_parsed_results()
         private$free_file_descriptors()