Skip to content

Commit 911bd1d

Browse files
author
hhaensel
committed
fix Linter warnings
1 parent cf2d74c commit 911bd1d

5 files changed

Lines changed: 7 additions & 6 deletions

File tree

src/ParsingTools.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ function struct_to_dict(s::T, f::Union{Nothing, Function} = !isnothing) where T
2626
ftest = isnothing(f) ? x -> true : f
2727

2828
isempty(fieldnames(T)) && return s
29-
Dict{Symbol, Any}(k => struct_to_dict(v) for (k, v) in zip(fieldnames(T), getfield.(RefValue(s), fieldnames(T))) if ftest(v))
29+
Dict{Symbol, Any}(k => struct_to_dict(v) for (k, v) in zip(fieldnames(T), getfield.(Base.RefValue(s), fieldnames(T))) if ftest(v))
3030
end
3131

3232
function deserialize!(d::Dict{T, Any}) where T

src/Stipple.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ export render, htmldiv, js_attr, render_component
116116
export setchannel, getchannel
117117

118118
# compatibility with Observables 0.3
119-
isempty(methods(notify, Observables)) && (Base.notify(observable::AbstractObservable) = Observables.notify!(observable))
119+
isempty(methods(notify, Observables)) && (Base.notify(observable::AbstractObservable) = Observables.notify(observable))
120120

121121
include("TimeOut.jl")
122122
include("ParsingTools.jl")

src/Theme.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ Utility functions for working with themes.
33
"""
44
module Theme
55

6-
using Genie
7-
using Stipple
6+
import Genie
7+
import Stipple
8+
using Stipple.Elements: stylesheet
89

910
import Base.RefValue
1011

src/Typography.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ julia> Typography.header("Hello", size = 2)
2323
function header(args...; size::Int = 1, kwargs...)
2424
1 <= size <= 6 || error("Invalid header size - expected 1:6")
2525
func = getproperty(Genie.Renderer.Html, Symbol("h$size"))
26-
func(class="text-h$size", args...; kwargs...) |> ParsedHTMLString
26+
func(class="text-h$size", args...; kwargs...) |> Genie.Renderer.Html.ParsedHTMLString
2727
end
2828

2929
end

src/stipple/rendering.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ function js_mixin(m::Mixin, js_f, delim)
199199

200200
no_modifiers = isempty(prefix) && isempty(postfix) || js_f (js_methods, js_computed, js_watch)
201201
add_fixes(s) = Symbol(prefix, s, postfix)
202-
add_fixes(s::JSONText) = Symbol(s.s)
202+
add_fixes(s::JSONText) = Symbol(json(s))
203203
xx = collect_js([js_f(M)], delim; pre = strip, key_replacement = no_modifiers ? identity : add_fixes)
204204

205205
isempty(prefix) && isempty(postfix) && return xx

0 commit comments

Comments
 (0)