Address PR review comments: fix placeholders, remove commented code, fix test structure

Co-authored-by: submarcos <7448208+submarcos@users.noreply.github.com>

Author: Copilot

geotrek/common/mixins/models.py

@@ -505,7 +505,7 @@ class BBoxMixin(models.Model):
     envelope = models.GeneratedField(
         expression=Envelope(Transform("geom", settings.API_SRID)),
         db_persist=True,
-        output_field=models.GeometryField(),
+        output_field=models.GeometryField(srid=settings.API_SRID),
     )
 
     @property

geotrek/maintenance/filters.py

@@ -240,7 +240,6 @@ class InterventionFilterSet(
             url="zoning:city-autocomplete",
             attrs={
                 "data-placeholder": _("City"),
-                #'data-theme': 'bootstrap4'
             },
         ),
     )
@@ -251,8 +250,7 @@ class InterventionFilterSet(
         widget=autocomplete.ModelSelect2Multiple(
             url="zoning:district-autocomplete",
             attrs={
-                "data-placeholder": _("City"),
-                # 'data-theme': 'bootstrap4'
+                "data-placeholder": _("District"),
             },
         ),
     )
@@ -303,7 +301,6 @@ class ProjectFilterSet(StructureRelatedFilterSet):
             url="zoning:city-autocomplete",
             attrs={
                 "data-placeholder": _("City"),
-                #'data-theme': 'bootstrap4'
             },
         ),
     )
@@ -314,8 +311,7 @@ class ProjectFilterSet(StructureRelatedFilterSet):
         widget=autocomplete.ModelSelect2Multiple(
             url="zoning:district-autocomplete",
             attrs={
-                "data-placeholder": _("City"),
-                # 'data-theme': 'bootstrap4'
+                "data-placeholder": _("District"),
             },
         ),
     )

geotrek/sensitivity/tests/test_admin.py

@@ -31,11 +31,10 @@ def test_returns_empty_queryset_if_no_species(self):
         queryset = self.admin.get_queryset(None)
         self.assertEqual(queryset.count(), 0)
 
+    def test_admin_changelist(self):
+        admin_user = UserFactory(is_staff=True, is_superuser=True)
+        self.client.force_login(admin_user)
 
-def test_admin_changelist(self):
-    admin_user = UserFactory(is_staff=True, is_superuser=True)
-    self.client.force_login(admin_user)
-
-    url = reverse("admin:sensitivity_species_changelist")
-    response = self.client.get(url)
-    self.assertEqual(response.status_code, 200)
+        url = reverse("admin:sensitivity_species_changelist")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)

geotrek/signage/models.py

@@ -378,7 +378,7 @@ def geom(self, value):
 
     @property
     def signage_display(self):
-        return f'<img src="{settings.STATIC_URL}images/signage-16.png" title="{_("Signage")}" />'
+        return f'<img src="{settings.STATIC_URL}images/signage-16.png" title="{_("Signage")}">'
 
     @property
     def order_lines(self):

geotrek/templates/mapentity/base_site.html

@@ -90,5 +90,5 @@
 
 {% block extrahead %}
     {{ block.super }}
-    <link rel="stylesheet" type="text/css" href="{% static 'style.css' %}"/>
+    <link rel="stylesheet" type="text/css" href="{% static 'common/style.css' %}"/>
 {% endblock %}

geotrek/zoning/filters.py

@@ -66,7 +66,7 @@ class ZoningFilterSet(FilterSet):
         widget=autocomplete.ModelSelect2Multiple(
             url="zoning:district-autocomplete",
             attrs={
-                "data-placeholder": _("City"),
+                "data-placeholder": _("District"),
             },
         ),
     )

geotrek/zoning/forms.py

@@ -16,7 +16,6 @@ def __init__(self, *args, **kwargs):
                     url="zoning:city-autocomplete-bbox",
                     attrs={
                         "data-placeholder": _("City"),
-                        #'data-theme': 'bootstrap4'
                     },
                 ),
                 required=False,
@@ -29,7 +28,6 @@ def __init__(self, *args, **kwargs):
                     url="zoning:district-autocomplete-bbox",
                     attrs={
                         "data-placeholder": _("District"),
-                        #'data-theme': 'bootstrap4'
                     },
                 ),
                 required=False,

geotrek/zoning/views.py

@@ -52,7 +52,7 @@ def autocomplete(self, request, *args, **kwargs):
             instance = qs.first()
             if instance is None:
                 return Response({})
-            serializer = self.serializer_autocomplete_class(qs.first())
+            serializer = self.serializer_autocomplete_class(instance)
             data = serializer.data
         else:
             q = self.request.query_params.get(