Merge pull request #35351 from storybookjs/review-quality-refactor #335
pull[bot]fork-checks.yml
on: push
Core Type Checking
11m 57s
Core Formatting
1m 42s
Matrix: test
Annotations
5 errors and 4 warnings
|
Core Unit Tests, windows-latest
Process completed with exit code 1.
|
|
[@storybook/codemod] src/index.test.ts > runCodemod > should handle recursive glob patterns:
code/lib/codemod/src/index.test.ts#L116
AssertionError: expected 'import { Meta, Story } from \'@storyb…' not to contain 'Template.bind({})'
- Expected
+ Received
- Template.bind({})
+ import { Meta, Story } from '@storybook/react-vite'
+
+ import { Chart, ChartProps } from './chart'
+
+ export default {
+ component: Chart,
+ title: 'Chart',
+ } as Meta
+
+ const Template: Story<ChartProps> = (args) => <Chart {...args} />
+
+ export const SimpleBar = Template.bind({})
+ SimpleBar.args = { name: 'test' }
+
❯ src/index.test.ts:116:25
|
|
[@storybook/codemod] src/index.test.ts > runCodemod > should handle glob patterns:
code/lib/codemod/src/index.test.ts#L95
AssertionError: expected 'import { Meta, Story } from \'@storyb…' not to contain 'Template.bind({})'
- Expected
+ Received
- Template.bind({})
+ import { Meta, Story } from '@storybook/react-vite'
+
+ import { Chart, ChartProps } from './chart'
+
+ export default {
+ component: Chart,
+ title: 'Chart',
+ } as Meta
+
+ const Template: Story<ChartProps> = (args) => <Chart {...args} />
+
+ export const SimpleBar = Template.bind({})
+ SimpleBar.args = { name: 'test' }
+
❯ src/index.test.ts:95:25
|
|
[@storybook/codemod] src/index.test.ts > runCodemod > should handle filenames with spaces:
code/lib/codemod/src/index.test.ts#L77
AssertionError: expected 'import { Meta, Story } from \'@storyb…' not to contain 'Template.bind({})'
- Expected
+ Received
- Template.bind({})
+ import { Meta, Story } from '@storybook/react-vite'
+
+ import { Chart, ChartProps } from './chart'
+
+ export default {
+ component: Chart,
+ title: 'Chart',
+ } as Meta
+
+ const Template: Story<ChartProps> = (args) => <Chart {...args} />
+
+ export const SimpleBar = Template.bind({})
+ SimpleBar.args = { name: 'test' }
+
❯ src/index.test.ts:77:24
|
|
[@storybook/codemod] src/index.test.ts > runCodemod > should transform CSF2 Template.bind({}) files with csf-2-to-3:
code/lib/codemod/src/index.test.ts#L62
AssertionError: expected 'import { Meta, Story } from \'@storyb…' not to contain 'Template.bind({})'
- Expected
+ Received
- Template.bind({})
+ import { Meta, Story } from '@storybook/react-vite'
+
+ import { Chart, ChartProps } from './chart'
+
+ export default {
+ component: Chart,
+ title: 'Chart',
+ } as Meta
+
+ const Template: Story<ChartProps> = (args) => <Chart {...args} />
+
+ export const SimpleBar = Template.bind({})
+ SimpleBar.args = { name: 'test' }
+
❯ src/index.test.ts:62:24
|
|
Core Formatting
Cache save failed.
|
|
Core Unit Tests, ubuntu-latest
Cache save failed.
|
|
Core Type Checking
Cache save failed.
|
|
Core Unit Tests, windows-latest
Cache save failed.
|