Replace std::reverse with Abseil container algorithms.

This change replaces calls to `std::reverse(container.begin(), container.end())` with `absl::c_reverse`. The Abseil versions are more concise and often safer as they operate directly on the container.

PiperOrigin-RevId: 937649754

Author: apivovarov

third_party/xla/xla/hlo/analysis/shape_tracker.cc

@@ -271,8 +271,8 @@ ShapeTracker::BufferView ShapeTracker::BufferView::FromShape(
     view.extents_.push_back(shape.dimensions(i));
     stride *= shape.dimensions(i);
   }
-  std::reverse(view.strides_.begin(), view.strides_.end());
-  std::reverse(view.extents_.begin(), view.extents_.end());
+  absl::c_reverse(view.strides_);
+  absl::c_reverse(view.extents_);
   if (view.strides_.empty()) {
     view.strides_.push_back(1);
     view.extents_.push_back(1);
@@ -929,7 +929,7 @@ std::vector<ShapeTracker::Step> ShapeTracker::OptimizeSteps(
                                      input_shape.dimensions().end());
 
   std::vector<int64_t> mapping(current_shape.size());
-  std::iota(mapping.begin(), mapping.end(), 0);
+  absl::c_iota(mapping, 0);
 
   // If the final step is a reshape, skip it for two reasons:
   // - Unlike other steps, it may contain degenerate dimensions which

third_party/xla/xla/hlo/builder/lib/BUILD

@@ -584,12 +584,15 @@ cc_library(
     name = "quantize",
     hdrs = ["quantize.h"],
     deps = [
-        ":constants",
+        "//xla:shape_util",
         "//xla:types",
         "//xla:util",
         "//xla:xla_data_proto_cc",
         "//xla/hlo/builder:xla_builder",
         "//xla/tsl/platform:status_macros",
+        "@com_google_absl//absl/algorithm:container",
+        "@com_google_absl//absl/status:statusor",
+        "@com_google_absl//absl/strings:string_view",
         "@tsl//tsl/platform:bfloat16",
     ],
 )

third_party/xla/xla/hlo/builder/lib/quantize.h

@@ -16,14 +16,18 @@ limitations under the License.
 #ifndef XLA_HLO_BUILDER_LIB_QUANTIZE_H_
 #define XLA_HLO_BUILDER_LIB_QUANTIZE_H_
 
-#include <algorithm>
+#include <climits>
+#include <cstdint>
 #include <limits>
-#include <numeric>
+#include <type_traits>
 #include <vector>
 
+#include "absl/algorithm/container.h"
+#include "absl/status/statusor.h"
+#include "absl/strings/string_view.h"
 #include "xla/tsl/platform/status_macros.h"
-#include "xla/hlo/builder/lib/constants.h"
 #include "xla/hlo/builder/xla_builder.h"
+#include "xla/shape.h"
 #include "xla/types.h"
 #include "xla/util.h"
 #include "xla/xla_data.pb.h"
@@ -122,8 +126,7 @@ inline XlaOp Dequantize(XlaOp input, const QuantizedRange& range,
     }
 
     std::vector<int64_t> shift_transpose_dimensions(shape.dimensions().size());
-    std::iota(shift_transpose_dimensions.begin(),
-              shift_transpose_dimensions.end(), 0);
+    absl::c_iota(shift_transpose_dimensions, 0);
     shift_transpose_dimensions.insert(shift_transpose_dimensions.begin(), 1,
                                       shape.dimensions().size());
 
@@ -156,8 +159,8 @@ inline XlaOp Dequantize(XlaOp input, const QuantizedRange& range,
     }
 
     std::vector<int64_t> transpose_dimensions(shape.dimensions().size());
-    std::iota(transpose_dimensions.begin(), transpose_dimensions.end(), 1);
-    std::reverse(transpose_dimensions.begin(), transpose_dimensions.end());
+    absl::c_iota(transpose_dimensions, 1);
+    absl::c_reverse(transpose_dimensions);
     transpose_dimensions.insert(transpose_dimensions.begin() + 1, 1, 0);
 
     // Transpose the result to be [dn, unpack_size, dn-1, ..., d1, d0].
@@ -173,8 +176,8 @@ inline XlaOp Dequantize(XlaOp input, const QuantizedRange& range,
 
     // Transpose the result to be [d0, d1, ..., dn-1, dn * unpack_size].
     std::vector<int64_t> result_dimensions(shape.dimensions().size());
-    std::iota(result_dimensions.begin(), result_dimensions.end(), 0);
-    std::reverse(result_dimensions.begin(), result_dimensions.end());
+    absl::c_iota(result_dimensions, 0);
+    absl::c_reverse(result_dimensions);
 
     return Transpose(reshaped_result, result_dimensions);
   });

third_party/xla/xla/hlo/ir/BUILD

@@ -101,7 +101,6 @@ cc_library(
         "//xla/service:mapped_ptr_container_sorter",
         "//xla/service:metrics_proto_cc",
         "//xla/service:name_uniquer",
-        "//xla/tsl/concurrency:ref_count",
         "//xla/tsl/lib/gtl:iterator_range",
         "//xla/tsl/lib/gtl:map_util",
         "//xla/tsl/platform:env",

third_party/xla/xla/hlo/ir/hlo_computation.cc

@@ -55,7 +55,6 @@ limitations under the License.
 #include "xla/hlo/ir/hlo_instructions.h"
 #include "xla/hlo/ir/hlo_module.h"
 #include "xla/hlo/ir/hlo_opcode.h"
-#include "xla/hlo/ir/hlo_payload_deduplicator.h"
 #include "xla/hlo/ir/hlo_print_options.h"
 #include "xla/hlo/ir/ptrvec.h"
 #include "xla/literal.h"
@@ -71,9 +70,7 @@ limitations under the License.
 #include "xla/shape_util.h"
 #include "xla/status_macros.h"
 #include "xla/tsl/lib/gtl/iterator_range.h"
-#include "xla/tsl/platform/errors.h"
 #include "xla/tsl/platform/logging.h"
-#include "xla/tsl/platform/statusor.h"
 #include "xla/util.h"
 #include "xla/xla_data.pb.h"
 
@@ -1082,7 +1079,7 @@ HloComputation::MakeInstructionPostOrderWithReshapeFirst() const {
     }
   }
 
-  std::reverse(sorted.begin(), sorted.end());
+  absl::c_reverse(sorted);
   CHECK_EQ(sorted.size(), instruction_count());
   return sorted;
 }

third_party/xla/xla/hlo/ir/hlo_instruction.cc

@@ -85,11 +85,9 @@ limitations under the License.
 #include "xla/side_effect_util.h"
 #include "xla/sort_json.h"
 #include "xla/status_macros.h"
-#include "xla/tsl/concurrency/ref_count.h"
 #include "xla/tsl/lib/gtl/iterator_range.h"
 #include "xla/tsl/lib/gtl/map_util.h"
 #include "xla/tsl/platform/logging.h"  // IWYU pragma: keep
-#include "xla/tsl/platform/statusor.h"
 #include "xla/util.h"
 #include "xla/xla_data.pb.h"
 
@@ -3017,7 +3015,7 @@ HloInstruction::LatestNonGteAncestorAndIndex() const {
   }
 
   // We built up index in the reverse order from what we want.
-  std::reverse(index.begin(), index.end());
+  absl::c_reverse(index);
 
   return {hlo, index};
 }

third_party/xla/xla/hlo/pass/BUILD

@@ -127,6 +127,7 @@ xla_cc_test(
         "//xla/tsl/lib/core:status_test_util",
         "//xla/tsl/platform:statusor",
         "//xla/tsl/platform:test_main",
+        "@com_google_absl//absl/algorithm:container",
         "@com_google_absl//absl/container:flat_hash_set",
         "@com_google_absl//absl/status",
         "@com_google_absl//absl/status:statusor",

third_party/xla/xla/hlo/pass/hlo_pass_pipeline_test.cc

@@ -15,13 +15,13 @@ limitations under the License.
 
 #include "xla/hlo/pass/hlo_pass_pipeline.h"
 
-#include <algorithm>
 #include <memory>
 #include <string>
 #include <vector>
 
 #include <gmock/gmock.h>
 #include <gtest/gtest.h>
+#include "absl/algorithm/container.h"
 #include "absl/container/flat_hash_set.h"
 #include "absl/status/status.h"
 #include "absl/status/statusor.h"
@@ -84,7 +84,7 @@ class ReverseStringModulePass : public HloModulePass {
          module->computations(execution_threads)) {
       HloInstruction* root = computation->root_instruction();
       std::string name(root->name());
-      std::reverse(name.begin(), name.end());
+      absl::c_reverse(name);
       root->SetAndSanitizeName(name);
       changed = true;
     }

third_party/xla/xla/hlo/tools/hlo_diff/utils/BUILD

@@ -77,6 +77,7 @@ cc_library(
     srcs = ["text_diff.cc"],
     hdrs = ["text_diff.h"],
     deps = [
+        "@com_google_absl//absl/algorithm:container",
         "@com_google_absl//absl/base:no_destructor",
         "@com_google_absl//absl/container:flat_hash_map",
         "@com_google_absl//absl/strings:string_view",

third_party/xla/xla/hlo/tools/hlo_diff/utils/text_diff.cc

@@ -20,6 +20,7 @@ limitations under the License.
 #include <utility>
 #include <vector>
 
+#include "absl/algorithm/container.h"
 #include "absl/base/no_destructor.h"
 #include "absl/container/flat_hash_map.h"
 #include "absl/strings/string_view.h"
@@ -122,7 +123,7 @@ void ComputeDiffRecursive(absl::string_view left, absl::string_view right,
         j--;
       }
     }
-    std::reverse(reversed_chunks.begin(), reversed_chunks.end());
+    absl::c_reverse(reversed_chunks);
     for (const auto& chunk : reversed_chunks) {
       MergeOrPushChunk(chunk.type, chunk.text, chunks);
     }