Absorb stale reads in the recording icon assert

The develop nightly on API 34 leaked a raw StaleObjectException from
assertRecordingView: waitToAppear absorbs staleness while waiting, but the
returned node can go stale before isDisplayed() reads visibleCenter. Use the
stale-safe waitDisplayed with the same 30s window, so the real failure is
reported instead of the stale read.

Author: andremion

demo-app/src/androidTestE2etestingDebug/kotlin/io/getstream/video/android/robots/UserRobotCallAsserts.kt

@@ -206,7 +206,12 @@ fun UserRobot.assertRecordingView(isDisplayed: Boolean): UserRobot {
     if (isDisplayed) {
         // The backend composite recorder can take 20-30s to actually start and emit
         // call.recording_started, so the icon needs a longer window than the 5s default.
-        assertTrue(CallPage.recordingIcon.waitToAppear(timeOutMillis = 30.seconds).isDisplayed())
+        // waitDisplayed also absorbs stale reads: the node returned by waitToAppear could
+        // go stale before isDisplayed() and leak a StaleObjectException.
+        assertTrue(
+            "Recording icon",
+            CallPage.recordingIcon.waitDisplayed(timeOutMillis = 30.seconds),
+        )
         // After a network drop the label can briefly read "Reconnecting.." before it settles
         // back to "Recording", so poll instead of asserting on the first read.
         val callInfoText = CallPage.callInfoView.waitForText(