Start the outgoing call service in joinAndRing and cover its notification

The caller had no outgoing call notification in the join-and-ring flow: the
notification is posted by the foreground service started with
TRIGGER_OUTGOING_CALL, which only registerOutgoingRing() starts, and only
the create-with-ring path called it. joinAndRing only called markRinging(),
so no service and no notification (setActiveCall logs 'Outgoing call service
should already be running'). On develop this was sometimes masked when the
ringing state flapped to Idle at setActiveCall time and the ongoing service
started instead; with the deterministic Outgoing state it never rendered.

- joinAndRing now calls registerOutgoingRing() on ring success, which
  registers the ringing call exactly like markRinging() and also starts the
  outgoing call service, mirroring the create-with-ring path.
- The outgoing ringing E2E test asserts the notification both ways: shown
  while the outgoing screen is up, gone after the decline. The check reads
  NotificationManager.activeNotifications in the app process and matches the
  notification title, because the outgoing screen shows the same
  'Calling...' text in the shade and the notification is posted on the
  ongoing calls channel.
- CallJoinCoordinatorTest verifies registerOutgoingRing on ring success.

Verified locally on an API 35 emulator through the real fastlane flow: the
test fails at the notification assert with the old markRinging() code and
passes with the fix.

Author: andremion

demo-app/src/androidTestE2etestingDebug/kotlin/io/getstream/video/android/robots/UserRobotCallAsserts.kt

@@ -16,12 +16,15 @@
 
 package io.getstream.video.android.robots
 
+import android.app.Notification
+import android.app.NotificationManager
 import androidx.test.uiautomator.BySelector
 import io.getstream.video.android.pages.CallPage
 import io.getstream.video.android.pages.CallPage.SettingsMenu
 import io.getstream.video.android.pages.RingPage
 import io.getstream.video.android.robots.UserControls.DISABLE
 import io.getstream.video.android.robots.UserControls.ENABLE
+import io.getstream.video.android.uiautomator.appContext
 import io.getstream.video.android.uiautomator.defaultTimeout
 import io.getstream.video.android.uiautomator.device
 import io.getstream.video.android.uiautomator.findObject
@@ -305,6 +308,30 @@ fun UserRobot.assertOutgoingCall(audioOnly: Boolean = true, isDisplayed: Boolean
     return this
 }
 
+/**
+ * Asserts the presence of the outgoing call notification, which the outgoing call foreground
+ * service posts with the "Calling..." title (on the ongoing calls channel, see
+ * getSimpleOngoingCallNotification). The instrumentation runs inside the app process, so the
+ * check reads NotificationManager.activeNotifications directly instead of matching text in
+ * the notification shade, where the outgoing screen shows the same "Calling..." text.
+ * The service start and stop are asynchronous, so both directions poll.
+ */
+fun UserRobot.assertOutgoingCallNotification(isDisplayed: Boolean): UserRobot {
+    val title = appContext.getString(
+        io.getstream.video.android.core.R.string.stream_video_outgoing_call_notification_title,
+    )
+    val notificationManager = appContext.getSystemService(NotificationManager::class.java)
+    fun displayed() = notificationManager.activeNotifications.any {
+        it.notification.extras.getCharSequence(Notification.EXTRA_TITLE)?.toString() == title
+    }
+    val endTime = System.currentTimeMillis() + defaultTimeout
+    while (displayed() != isDisplayed && System.currentTimeMillis() < endTime) {
+        Thread.sleep(250)
+    }
+    assertEquals("Outgoing call notification displayed", isDisplayed, displayed())
+    return this
+}
+
 fun UserRobot.assertConnectingView(): UserRobot {
     assertEquals("Connecting...", RingPage.callProgressBar.waitToAppear().text)
     // Connecting covers the same call join round-trip as waitForCallToStart, which can

demo-app/src/androidTestE2etestingDebug/kotlin/io/getstream/video/android/tests/RingingTests.kt

@@ -21,6 +21,7 @@ import io.getstream.video.android.robots.assertAudioCallControls
 import io.getstream.video.android.robots.assertConnectingView
 import io.getstream.video.android.robots.assertIncomingCall
 import io.getstream.video.android.robots.assertOutgoingCall
+import io.getstream.video.android.robots.assertOutgoingCallNotification
 import io.getstream.video.android.robots.assertThatCallIsEnded
 import io.getstream.video.android.robots.assertVideoCallControls
 import io.qameta.allure.kotlin.Allure.step
@@ -80,12 +81,18 @@ class RingingTests : StreamTestCase() {
         step("THEN the outgoing call starts") {
             userRobot.assertOutgoingCall(audioOnly = true, isDisplayed = true)
         }
+        step("AND the outgoing call notification is displayed") {
+            userRobot.assertOutgoingCallNotification(isDisplayed = true)
+        }
         step("WHEN user rejects the outgoing call") {
             userRobot.declineOutgoingCall()
         }
         step("THEN the outgoing call ends") {
             userRobot.assertOutgoingCall(isDisplayed = false)
         }
+        step("AND the outgoing call notification is dismissed") {
+            userRobot.assertOutgoingCallNotification(isDisplayed = false)
+        }
     }
 
     @AllureId("7776")

stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/call/components/CallJoinCoordinator.kt

@@ -327,7 +327,11 @@ internal class CallJoinCoordinator(
             logger.d { "[joinAndRing] Joined #ringing; #track; ring: $members" }
             apiClient.ring(RingCallRequest(isVideoEnabled(), members)).map {
                 logger.d { "[joinAndRing] Ringed #ringing; #track; ring: $members" }
-                callRegistry.markRinging()
+                // registerOutgoingRing registers the ringing call AND starts the outgoing call
+                // foreground service, like the create-with-ring path does. markRinging alone
+                // never started the service here, so the caller had no outgoing notification
+                // (setActiveCall logs "Outgoing call service should already be running").
+                callRegistry.registerOutgoingRing()
                 // An event that arrived before the ring completed (e.g. call.session_started)
                 // computed the ringing state without the ringing call registered. Recompute so
                 // the state cannot stay Idle when no further coordinator event arrives.

stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/call/components/CallJoinCoordinatorTest.kt

@@ -677,6 +677,9 @@ class CallJoinCoordinatorTest {
 
         assertThat(result).isInstanceOf(Success::class.java)
         coVerify { apiClient.ring(any<RingCallRequest>()) }
+        // registerOutgoingRing (not markRinging) so the outgoing call foreground service
+        // starts and the caller gets the outgoing call notification, like create-with-ring.
+        verify { callRegistry.registerOutgoingRing() }
     }
 
     @Test