Breaking change in firewall rule support for RoCE (RDMA) networks used by A3 Ultra and A4 VMs

[tpdownes]

RoCE (RDMA) networks no longer support firewall rules. These network types are used by A3 Ultra and A4 VM types. Older blueprints will fail with a validation warning; the solution is to remove the firewall rules following the examples in 312d7fb.

The validation warning will resemble this message:

Error: Invalid value for variable

  on main.tf line 62, in module "slurm-rdma-net":
  62:   firewall_rules = [{
  63:     allow = [{
  64:       protocol = "tcp"
  65:       }, {
  66:       protocol = "udp"
  67:       }, {
  68:       protocol = "icmp"
  69:     }]
  70:     name   = "${var.deployment_name}-internal-rdma"
  71:     ranges = [var.rdma_net_range]
  72:   }]
    ├────────────────
    │ var.firewall_rules is tuple with 1 element

DEPRECATED: firewall_rules can not be specified for gpu-rdma-vpc.

This was checked by the validation rule at
modules/embedded/modules/network/gpu-rdma-vpc/variables.tf:121,3-13.