fix flaky test because of string list order

kyasbal · kyasbal · commit aa8181195f8a · 2025-12-02T12:42:41.000+09:00
diff --git a/pkg/task/inspection/commonlogk8sauditv2/impl/grouper_tasks_test.go b/pkg/task/inspection/commonlogk8sauditv2/impl/grouper_tasks_test.go
@@ -23,6 +23,7 @@ import (
 	"github.com/GoogleCloudPlatform/khi/pkg/model/log"
 	commonlogk8sauditv2_contract "github.com/GoogleCloudPlatform/khi/pkg/task/inspection/commonlogk8sauditv2/contract"
 	"github.com/google/go-cmp/cmp"
+	"github.com/google/go-cmp/cmp/cmpopts"
 )
 
 type testScanTargetResourceInput struct {
@@ -341,7 +342,7 @@ kind: Binding`,
 				got = append(got, gotPaths)
 			}
 
-			if diff := cmp.Diff(got, tc.want); diff != "" {
+			if diff := cmp.Diff(got, tc.want, cmpopts.SortSlices(func(a, b string) bool { return a < b })); diff != "" {
 				t.Errorf("mismatch (-want +got): %s", diff)
 			}
 		})

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,7 @@ import (`
`23`	`23`	`"github.com/GoogleCloudPlatform/khi/pkg/model/log"`
`24`	`24`	`commonlogk8sauditv2_contract "github.com/GoogleCloudPlatform/khi/pkg/task/inspection/commonlogk8sauditv2/contract"`
`25`	`25`	`"github.com/google/go-cmp/cmp"`
	`26`	`+ "github.com/google/go-cmp/cmp/cmpopts"`
`26`	`27`	`)`
`27`	`28`
`28`	`29`	`type testScanTargetResourceInput struct {`
@@ -341,7 +342,7 @@ kind: Binding`,
`341`	`342`	`got = append(got, gotPaths)`
`342`	`343`	`}`
`343`	`344`
`344`		`- if diff := cmp.Diff(got, tc.want); diff != "" {`
	`345`	`+ if diff := cmp.Diff(got, tc.want, cmpopts.SortSlices(func(a, b string) bool { return a < b })); diff != "" {`
`345`	`346`	`t.Errorf("mismatch (-want +got): %s", diff)`
`346`	`347`	`}`
`347`	`348`	`})`