Skip to content

Commit e41646a

Browse files
committed
fix issues pointed by gemini-code-assist
1 parent 1713aa0 commit e41646a

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

pkg/core/inspection/taskbase/historymodifier_task.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import (
2222
"sync/atomic"
2323
"time"
2424

25-
"github.com/GoogleCloudPlatform/khi/pkg/common/errorreport"
2625
"github.com/GoogleCloudPlatform/khi/pkg/common/khictx"
2726
"github.com/GoogleCloudPlatform/khi/pkg/common/structured"
2827
"github.com/GoogleCloudPlatform/khi/pkg/common/worker"
@@ -85,8 +84,6 @@ func NewHistoryModifierTask[T any](tid taskid.TaskImplementationID[struct{}], hi
8584
pool := worker.NewPool(runtime.GOMAXPROCS(0))
8685
for _, group := range groupedLogs {
8786
pool.Run(func() {
88-
defer errorreport.CheckAndReportPanic()
89-
9087
var groupData T
9188
changedPaths := map[string]struct{}{}
9289
for _, l := range group.Logs {
@@ -101,8 +98,7 @@ func NewHistoryModifierTask[T any](tid taskid.TaskImplementationID[struct{}], hi
10198
} else {
10299
yaml = string(yamlBytes)
103100
}
104-
slog.WarnContext(ctx, fmt.Sprintf("parser end with an error\n%s", err))
105-
slog.DebugContext(ctx, yaml)
101+
slog.WarnContext(ctx, "parser ended with an error", "error", err, "logContent", yaml)
106102
continue
107103
}
108104
cp, err := cs.FlushToHistory(builder)

0 commit comments

Comments
 (0)