Allow 12-hour notation in datetime fields

[ForeverFloating]

There are already abbreviations for custom time formats described in the Dates section of the user manual, but all time formats are restricted to 24 hour notation. It would be useful to also enable specifying times in 12 hour notation by adding an additional variable for 12-hour time and an AM/PM indicator.

[Manar-Elhabbal7]

Can I work on this issue?

[djmitche]

Sure!

[djmitche]

@Manar-Elhabbal7 how's it going?

[hamzahchaudhry]

Hi @djmitche, if this is still available, I’d be happy to work on it and would appreciate being assigned. I’ve personally run into cases where 12-hour datetime input would have been useful, so I’d be excited to help add support for it.

[djmitche]

Done!

[hamzahchaudhry]

Hi @djmitche, I’ve started looking into this and found the dateformat parsing/formatting logic in src/libshared/src/Datetime.cpp.

I’m planning to add:

• i for minimal-digit 12-hour time, e.g. 1 or 12
• I for two-digit 12-hour time, e.g. 01 or 12
• p for AM/PM, case-insensitive on input

Before I go further, does that naming fit the project’s conventions? Also, since the implementation is in the src/libshared submodule, should this be submitted first as a PR to GothenburgBitFactory/libshared, then update the Taskwarrior submodule pointer here?