fix(fields): rebase caller sub-input ids onto the generated field id

For unknown/third-party compound fields, gf_add_field preserved caller inputs verbatim, so dotted sub-input ids kept their assumed parent (e.g. 9.1) instead of the id generateFieldId assigns, orphaning the sub-inputs. Rebase dotted ids onto the generated field id (mirrors assignFieldIds); known compound types keep generateSubInputs unchanged. Live-verified on dev.test: 99.x inputs persist as 4.x.

Claude-Session: https://claude.ai/code/session_01LJHfTpQknHFs1j5ayj7fpo

Author: zackkatz

src/field-operations/field-manager.js

@@ -44,11 +44,15 @@ export class FieldManager {
     // Create field with type-specific defaults (none for unknown types)
     const field = this.createField(fieldId, fieldType, properties, fieldDef || {});
 
-    // Generate compound sub-inputs only for known compound types (address.1,
-    // name.3, …). Unknown types keep any caller-supplied `inputs` untouched.
+    // Known compound types (address, name, …) regenerate sub-inputs from the
+    // registry, keyed off the generated field id. Otherwise caller-supplied
+    // `inputs` are kept, but their dotted sub-input ids are rebased onto the
+    // generated field id so the parent reference matches (mirrors assignFieldIds).
     const isCompoundType = fieldDef?.storage?.type === 'compound';
     if (isCompoundType) {
       field.inputs = this.generateSubInputs(field, fieldDef);
+    } else if (Array.isArray(field.inputs)) {
+      field.inputs = this.rebaseSubInputIds(field.inputs, fieldId);
     }
 
     // Normalize layout grid properties (layoutGroupId, layoutGridColumnSpan)
@@ -202,6 +206,26 @@ export class FieldManager {
     return maxId + 1;
   }
 
+  /**
+   * Rebase dotted sub-input ids (e.g. "9.1") onto a new parent field id so each
+   * sub-input's parent reference matches the field it belongs to. Non-dotted and
+   * non-string ids pass through. Mirrors assignFieldIds in the field registry.
+   *
+   * @param {Array<object>} inputs
+   * @param {number|string} baseId
+   * @returns {Array<object>}
+   */
+  rebaseSubInputIds(inputs, baseId) {
+    return inputs.map((input) => {
+      const hasDottedId = input && typeof input.id === 'string' && input.id.includes('.');
+      if (!hasDottedId) {
+        return input;
+      }
+      const sub = input.id.slice(input.id.indexOf('.') + 1);
+      return { ...input, id: `${baseId}.${sub}` };
+    });
+  }
+
   /**
    * Create field with intelligent defaults from registry
    */

test/field-manager.test.js

@@ -259,23 +259,42 @@ test('FieldManager - addField', async (t) => {
     );
   });
 
-  await t.test('preserves caller-supplied inputs for an unknown compound-like type', async () => {
+  await t.test('rebases caller-supplied dotted sub-input ids onto the generated field id (unknown type)', async () => {
     const apiClient = createMockApiClient();
     const registry = createMockRegistry();
     const validator = createMockValidator();
     const manager = new FieldManager(apiClient, registry, validator);
 
+    // The caller guessed parent id 9, but the form's next id is 4. Sub-inputs
+    // must follow the generated field id (4.x), not stay orphaned at 9.x. Labels
+    // and other props are preserved.
     const result = await manager.addField(1, 'custom_compound', {
       label: 'Custom Compound',
-      inputs: [{ id: '4.1', label: 'Part A' }, { id: '4.2', label: 'Part B' }]
+      inputs: [{ id: '9.1', label: 'Part A' }, { id: '9.2', label: 'Part B' }]
     });
 
     assert.strictEqual(result.success, true);
+    assert.strictEqual(result.field.id, 4);
     assert.deepStrictEqual(result.field.inputs, [
       { id: '4.1', label: 'Part A' },
       { id: '4.2', label: 'Part B' }
     ]);
   });
+
+  await t.test('known compound type still gets registry sub-inputs keyed on the generated field id', async () => {
+    const apiClient = createMockApiClient();
+    const registry = createMockRegistry();
+    const validator = createMockValidator();
+    const manager = new FieldManager(apiClient, registry, validator);
+
+    const result = await manager.addField(1, 'address', { label: 'Mailing Address' });
+
+    assert.strictEqual(result.field.id, 4);
+    assert.deepStrictEqual(
+      result.field.inputs.map((i) => i.id),
+      ['4.1', '4.2', '4.3', '4.4', '4.5', '4.6']
+    );
+  });
 });
 
 test('FieldManager - updateField', async (t) => {