7 Junit tests are failing

[boundless29]

HI,

I ran this OOTB code. I am seeing 7 failures. Any idea why these 7 tests are failing. Your help is highly appreciated.

com.guidewire.cda.SavepointsProcessorTest > Testing SavepointsProcessor functionality SavepointsProcessor.checkExists test when savepoints directory
exists, and check if the savepoints json file exists FAILED
java.net.URISyntaxException

com.guidewire.cda.SavepointsProcessorTest > Testing SavepointsProcessor functionality SavepointsProcessor.readSavepoints should read savepoints from
a savepoints.json file in a given directory, or return empty Map if no savepoints file exist FAILED
java.net.URISyntaxException

com.guidewire.cda.SavepointsProcessorTest > Testing SavepointsProcessor functionality SavepointsProcessor.getSavepoints should get a savepoint for a
table from a savepoints.json file, which is an Option FAILED
java.net.URISyntaxException

com.guidewire.cda.SavepointsProcessorTest > Testing SavepointsProcessor functionality SavepointsProcessor.writeSavepoints should write the lastSucce
ssfulReadTimestamps to a savepoints.json file FAILED
java.net.URISyntaxException

com.guidewire.cda.SavepointsProcessorTest > Testing SavepointsProcessor functionality SavepointsProcessor.writeSavepoints should allow savepoint ent
ry to be updated multiple times, for the same table FAILED
java.net.URISyntaxException

com.guidewire.cda.TableReaderTest > Testing TableReader functionality TableReader.getFingerprintsWithUnprocessedRecords should retain all fingerprin
ts if no savepoint data exists FAILED
java.net.URISyntaxException

gw.cda.api.outputwriter.LocalOutputWriterTest > initializationError FAILED
org.scalatest.exceptions.NotAllowedException at LocalOutputWriterTest.scala:69
Caused by: java.net.URISyntaxException at LocalOutputWriterTest.scala:69

36 tests completed, 7 failed

[JohnPeel]

I'm also running into these issues on a Windows machine.

Looking at the code, it looks like FileBasedOutputWriter is expecting it's OutputWriterConfig.configPath to have a URI.
The tests pass a file path without the file:// so it's not a valid URI.

I've fixed it locally by changing the testWriterPath variable in the tests to a URI.

Unfortunately FileBasedOutputWriter is expecting a path that is a URI, but then passes that URI to a class that doesn't expect a URI.

I've fixed it by adding a try catch around getting the scheme from URI.

Index: src/main/scala/gw/cda/api/outputwriter/FileBasedOutputWriter.scala
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/main/scala/gw/cda/api/outputwriter/FileBasedOutputWriter.scala b/src/main/scala/gw/cda/api/outputwriter/FileBasedOutputWriter.scala
--- a/src/main/scala/gw/cda/api/outputwriter/FileBasedOutputWriter.scala	(revision ac6a57779ffc567a12d5c8c6cbe0f014cb43d443)
+++ b/src/main/scala/gw/cda/api/outputwriter/FileBasedOutputWriter.scala	(revision ec553e05a116a2ffc68d4e43476e62a05d251bdf)
@@ -12,7 +12,7 @@
 import org.apache.spark.sql.Row
 
 import java.io.StringWriter
-import java.net.URI
+import java.net.{URI, URISyntaxException}
 import scala.util.parsing.json.JSONObject
 
 trait FileBasedOutputWriter extends OutputWriter {
@@ -189,7 +189,14 @@
 
 object FileBasedOutputWriter {
   def apply(outputWriterConfig: OutputWriterConfig): FileBasedOutputWriter = {
-    new URI(outputWriterConfig.outputPath).getScheme match {
+    var scheme = ""
+    try {
+      scheme = new URI(outputWriterConfig.outputPath).getScheme
+    } catch {
+      case _: URISyntaxException => scheme = "file"
+    }
+
+    scheme match {
       case "s3" =>
         new S3OutputWriter(outputWriterConfig.outputPath, outputWriterConfig.includeColumnNames, outputWriterConfig.saveAsSingleFile, outputWriterConfig.saveIntoTimestampDirectory, outputWriterConfig.clientConfig)
       case _    =>

Looks like the change 1dc7239 on 11/2/2021 by Sushil Thasale caused this issue.