Naming: "constant" vs "value"

[arjun]

Should the string "macros" be called "constant" or "value"?

See https://github.com/FHIR/sql-on-fhir-v2/blob/master/input/pagecontent/view-definition.md#flattened-blood-pressure

[johngrimes]

I think this should be "constant.[path | expression]" vs "constant.value".

Unfortunately we have created a dependency between two of our polls 😄

[johngrimes]

The reason that I think this should be "value" is that I don't think that there is any requirement for this to be a valid expression/path.

We have defined this as being a naive string substitution, rather that something that gets evaluated to a result beforehand.

[gotdan]

I agree with @johngrimes - I'm going to assume that voting for "value" here means we have a structure like:

"constants": [
    {"name": "abc", "value": "def"}
]

with the alternative being a structure like:

"constants": [
    {"path": "abc", "value": "def"}
]

[johngrimes]

Ha, I was actually thinking that these were the two options:

"constants": [
    {"name": "abc", "value": "def"}
]

or

"constants": [
    {"name": "abc", "path": "def"}
]

[gotdan]

Oops, yup, I meant to write name and path for the second option! That will teach me to try to comment while being distracted by a toddler :)

[arjun]

Decision was to keep this structure:

"constants": [
    {"name": "abc", "value": "def"}
]