Skip to content

Commit 4496ff4

Browse files
authored
Merge pull request #101 from kbseah/master
Change wildcard for download path of SILVA database
2 parents 4684823 + f087306 commit 4496ff4

5 files changed

Lines changed: 22 additions & 13 deletions

File tree

PhyloFlash.pm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ This module contains helper functions shared by the phyloFlash scripts.
2828
2929
=cut
3030

31-
our $VERSION = "3.3b1";
31+
our $VERSION = "3.3b2";
3232
our @ISA = qw(Exporter);
3333
our @EXPORT = qw(
3434
$VERSION

README.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<img align="right" src="docs/phyloFlash_logo.png" width="200" alt="phyloFlash logo"/>
22

3-
# phyloFlash v3.3 beta 1
3+
# phyloFlash v3.3b2
44

55
[![GitHub (pre-)release](https://img.shields.io/github/release/HRGV/phyloflash/all.svg?label=Latest%20Version)]()
66
[![Bioconda](https://img.shields.io/conda/vn/Bioconda/phyloFlash.svg)](https://bioconda.github.io/recipes/phyloflash/README.html)
@@ -42,11 +42,11 @@ If you clone the repository directly off GitHub you might end up with a version
4242

4343
```bash
4444
# Download latest release
45-
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b1.tar.gz
46-
tar -xzf pf3.3b1.tar.gz
45+
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b2.tar.gz
46+
tar -xzf pf3.3b2.tar.gz
4747

4848
# Check for dependencies and install them if necessary
49-
cd phyloFlash-pf3.3b1
49+
cd phyloFlash-pf3.3b2
5050
./phyloFlash.pl -check_env
5151
```
5252

@@ -113,6 +113,9 @@ For further information **please refer to the [Manual](https://hrgv.github.io/ph
113113

114114
## Versions and changes
115115

116+
* v3.3 beta 2
117+
* New options to graphical comparison scripts, and other small bug fixes
118+
* Fix bug due to change in SILVA project file naming convention with SILVA 138 onwards
116119
* v3.3 beta 1
117120
* Add support for using SortMeRNA instead of BBmap for initial mapping step
118121
* Changes to how mapping data are hashed; process SAM file of initial mapping to fix known bugs with bitflag and read name reporting in BBmap and SortMeRNA

docs/index.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ If you clone the repository directly off GitHub you might end up with a version
4646

4747
```bash
4848
# Download latest release
49-
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b1.tar.gz
50-
tar -xzf pf3.3b1.tar.gz
49+
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b2.tar.gz
50+
tar -xzf pf3.3b2.tar.gz
5151

5252
# Check for dependencies and install them if necessary
53-
cd phyloFlash-pf3.3b1
53+
cd phyloFlash-pf3.3b2
5454
./phyloFlash.pl -check_env
5555
```
5656

docs/install.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ If you clone the repository directly off GitHub you might end up with a version
5252

5353
```bash
5454
# Download latest release
55-
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b1.tar.gz
56-
tar -xzf pf3.3b1.tar.gz
55+
wget https://github.com/HRGV/phyloFlash/archive/pf3.3b2.tar.gz
56+
tar -xzf pf3.3b2.tar.gz
5757
```
5858

5959
Alternatively clone the latest development version with Git:

phyloFlash_makedb.pl

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,8 @@ =head2 INPUT FILES
5959
This should be the Fasta-formatted SILVA SSURef file, clustered at 99% identity,
6060
with SILVA taxonomy strings in file header, and sequences truncated to SSU gene
6161
boundaries. The file name should be in the form
62-
I<SILVA_[Release]_SSURef_Nr99_tax_silva_trunc.fasta.gz>
62+
I<SILVA_[Release]_SSURef_Nr99_tax_silva_trunc.fasta.gz> (release 132 and before) or
63+
I<SILVA_[Release]_SSURef_NR99_tax_silva_trunc.fasta.gz> (from release 138 onwards)
6364
6465
=item --univec_file F<path/to/univec_db>
6566
@@ -172,9 +173,10 @@ =head1 COPYRIGHT AND LICENSE
172173
use Cwd;
173174
use Storable;
174175
use File::Spec;
176+
use File::Basename;
175177

176178
# URLS
177-
my $silva_url = "ftp.arb-silva.de/current/Exports/*_SSURef_Nr99_tax_silva_trunc.fasta.gz";
179+
my $silva_url = "ftp.arb-silva.de/current/Exports/*_SSURef_N?99_tax_silva_trunc.fasta.gz";
178180
my $univec_url = "ftp.ncbi.nlm.nih.gov/pub/UniVec/UniVec";
179181

180182
# constants
@@ -252,7 +254,11 @@ =head1 COPYRIGHT AND LICENSE
252254
}
253255

254256
# extract SILVA version
255-
my ($silva_release) = ($silva_file =~ m/SILVA_([^_]+)_/);
257+
# get file basename, in case a path is specified
258+
my ($silva_file_filename,
259+
$silva_file_dirs,
260+
$silva_file_suffix) = fileparse($silva_file);
261+
my ($silva_release) = ($silva_file_filename =~ m/SILVA_([^_]+)_/);
256262

257263
if (!$&) {
258264
err("Unable to extract version from SILVA database filename:",

0 commit comments

Comments
 (0)