Add mypy strict type checking with pre-commit and CI integration

Author: eli-the-wizard

.github/workflows/ci.yml

@@ -20,6 +20,9 @@ jobs:
       - name: Lint
         run: uv run ruff check
 
+      - name: Type check
+        run: uv run mypy src/linear_python_client
+
   test:
     runs-on: ubuntu-latest
     steps:

.pre-commit-config.yaml

@@ -0,0 +1,17 @@
+repos:
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.15.16
+    hooks:
+      - id: ruff
+        args: [--fix]
+      - id: ruff-format
+
+  - repo: local
+    hooks:
+      - id: mypy
+        name: mypy
+        entry: uv run mypy
+        args: [src/linear_python_client]
+        language: system
+        pass_filenames: false
+        types: [python]

pyproject.toml

@@ -36,6 +36,7 @@ build-backend = "uv_build"
 
 [dependency-groups]
 dev = [
+    "mypy>=1.11",
     "pytest>=8.0",
     "pytest-cov>=5.0",
     "respx>=0.21",
@@ -62,6 +63,11 @@ exclude_also = ["if __name__ == .__main__.:"]
 
 [tool.ruff]
 line-length = 100
+exclude = ["tests", "scripts"]
 
 [tool.ruff.lint]
 select = ["E", "F", "I", "UP", "B"]
+
+[tool.mypy]
+strict = true
+exclude = ["tests/", "scripts/"]

src/linear_python_client/client.py

@@ -320,7 +320,9 @@ def _raise_for_errors(self, errors: list[dict[str, Any]], response: httpx.Respon
                 complexity_reset=_to_int(h.get("X-RateLimit-Complexity-Reset")),
                 query_complexity=_to_int(h.get("X-Complexity")),
                 endpoint_requests_limit=_to_int(h.get("X-RateLimit-Endpoint-Requests-Limit")),
-                endpoint_requests_remaining=_to_int(h.get("X-RateLimit-Endpoint-Requests-Remaining")),
+                endpoint_requests_remaining=_to_int(
+                    h.get("X-RateLimit-Endpoint-Requests-Remaining")
+                ),
                 endpoint_requests_reset=_to_int(h.get("X-RateLimit-Endpoint-Requests-Reset")),
                 endpoint_name=h.get("X-RateLimit-Endpoint-Name"),
             )
@@ -334,10 +336,10 @@ def _raise_for_errors(self, errors: list[dict[str, Any]], response: httpx.Respon
     def _lookup_team(self, name_or_key: str) -> str:
         """Resolve a team display name or key to a UUID."""
         resp = self.find_team(FindTeamRequest(name=name_or_key))
-        if resp.team is not None:
+        if resp.team is not None and resp.team.id is not None:
             return resp.team.id
         resp = self.find_team(FindTeamRequest(key=name_or_key))
-        if resp.team is not None:
+        if resp.team is not None and resp.team.id is not None:
             return resp.team.id
         raise ValueError(f"Team not found: {name_or_key!r}")
 
@@ -349,30 +351,28 @@ def _lookup_user(self, name_or_email: str) -> str:
             else FindUserRequest(name=name_or_email)
         )
         user = self.find_user(req).user
-        if user is None:
+        if user is None or user.id is None:
             raise ValueError(f"User not found: {name_or_email!r}")
         return user.id
 
     def _lookup_project(self, name: str) -> str:
         """Resolve a project name to a UUID."""
         project = self.find_project(FindProjectRequest(name=name)).project
-        if project is None:
+        if project is None or project.id is None:
             raise ValueError(f"Project not found: {name!r}")
         return project.id
 
     def _lookup_label(self, name: str, *, team_id: str | None = None) -> str:
         """Resolve a label name to a UUID, optionally scoped to a team."""
         label = self.find_label(FindLabelRequest(name=name, team_id=team_id)).label
-        if label is None:
+        if label is None or label.id is None:
             raise ValueError(f"Label not found: {name!r}")
         return label.id
 
     def _lookup_workflow_state(self, name: str, team_id: str) -> str:
         """Resolve a workflow state name to a UUID within a team."""
-        state = self.find_workflow_state(
-            FindWorkflowStateRequest(team_id=team_id, name=name)
-        ).state
-        if state is None:
+        state = self.find_workflow_state(FindWorkflowStateRequest(team_id=team_id, name=name)).state
+        if state is None or state.id is None:
             raise ValueError(f"Workflow state {name!r} not found in team {team_id!r}")
         return state.id
 

src/linear_python_client/models/responses.py

@@ -8,6 +8,8 @@
 
 from __future__ import annotations
 
+from collections.abc import Iterator
+
 from pydantic import Field
 
 from .entities import (
@@ -34,7 +36,7 @@ class ConnectionResponse[NodeT](LinearModel):
     nodes: list[NodeT] = Field(default_factory=list)
     page_info: PageInfo = Field(default_factory=PageInfo)
 
-    def __iter__(self):
+    def __iter__(self) -> Iterator[NodeT]:  # type: ignore[override]
         """Iterate over `nodes`."""
         return iter(self.nodes)