kk

Author: HaibaraAi137

frontend/src/views/PaperEditor.tsx

@@ -1,5 +1,5 @@
 import { useEffect, useState } from "react";
-import { AlertCircle, CheckCircle2, FileWarning, Hammer, Lock, Save, ShieldCheck } from "lucide-react";
+import { AlertCircle, CheckCircle2, ExternalLink, FileText, FileWarning, Hammer, Lock, Save, ShieldCheck } from "lucide-react";
 import { useQueryClient } from "@tanstack/react-query";
 import { ApiError, api } from "../api/client";
 import type { CompileResult, PaperStatus } from "../api/client";
@@ -20,6 +20,13 @@ export function PaperEditor({ projectId, isRunning }: Props) {
   const [compiling, setCompiling] = useState(false);
   const [strictCompiling, setStrictCompiling] = useState(false);
   const [compileResult, setCompileResult] = useState<CompileResult | null>(null);
+  // "source" = LaTeX editor; "pdf" = inline-rendered paper.pdf preview.
+  // The two views share the compile + save buttons in the footer so the
+  // user can flip between them without losing context.
+  const [view, setView] = useState<"source" | "pdf">("source");
+  // Bumped after every successful compile to bust the iframe cache so the
+  // PDF view shows the freshly built file instead of a stale cached page.
+  const [pdfVersion, setPdfVersion] = useState(0);
   const queryClient = useQueryClient();
 
   useEffect(() => {
@@ -68,6 +75,9 @@ export function PaperEditor({ projectId, isRunning }: Props) {
       const result = await api.compilePaper(projectId, { strict });
       setCompileResult(result);
       queryClient.invalidateQueries({ queryKey: queryKeys.paperStatus(projectId) });
+      // Bump the PDF version so any open preview iframe reloads against the
+      // newly-built paper.pdf instead of showing a stale cached version.
+      if (result.passed) setPdfVersion((v) => v + 1);
     } catch (e) {
       setCompileResult({
         passed: false,
@@ -82,6 +92,8 @@ export function PaperEditor({ projectId, isRunning }: Props) {
     }
   }
 
+  const pdfSrc = `/api/projects/${encodeURIComponent(projectId)}/paper/pdf?v=${pdfVersion}`;
+
   return (
     <div className="paperPane">
       <header className="paperHeader">
@@ -91,6 +103,22 @@ export function PaperEditor({ projectId, isRunning }: Props) {
           {data.pi_locks.length} locks
           {dirty && <span className="dirtyBadge"> · unsaved</span>}
         </span>
+        <div className="paperViewToggle">
+          <button
+            className={view === "source" ? "active" : ""}
+            onClick={() => setView("source")}
+            title="Edit paper.tex source"
+          >
+            <FileText size={13} /> Source
+          </button>
+          <button
+            className={view === "pdf" ? "active" : ""}
+            onClick={() => setView("pdf")}
+            title="View compiled paper.pdf inline"
+          >
+            <Hammer size={13} /> PDF
+          </button>
+        </div>
       </header>
 
       {data.pi_locks.length > 0 && (
@@ -106,18 +134,42 @@ export function PaperEditor({ projectId, isRunning }: Props) {
 
       {status && <ConstructionStatusPanel status={status} />}
 
-      <textarea
-        className="paperEditor"
-        value={draft}
-        onChange={(event) => setDraft(event.target.value)}
-        spellCheck={false}
-        disabled={isRunning}
-        placeholder={
-          isRunning
-            ? "Iteration running; paper.tex is locked until it finishes."
-            : "Edit paper.tex. Use % PI-LOCK BEGIN id=\"...\" / END to protect regions."
-        }
-      />
+      {view === "source" ? (
+        <textarea
+          className="paperEditor"
+          value={draft}
+          onChange={(event) => setDraft(event.target.value)}
+          spellCheck={false}
+          disabled={isRunning}
+          placeholder={
+            isRunning
+              ? "Iteration running; paper.tex is locked until it finishes."
+              : "Edit paper.tex. Use % PI-LOCK BEGIN id=\"...\" / END to protect regions."
+          }
+        />
+      ) : (
+        <div className="paperPdfWrapper">
+          <object
+            key={pdfVersion}
+            data={pdfSrc}
+            type="application/pdf"
+            className="paperPdfFrame"
+          >
+            <div className="advisorEmpty">
+              <p>
+                Your browser cannot embed PDFs.{" "}
+                <a href={pdfSrc} target="_blank" rel="noopener noreferrer">
+                  Open paper.pdf <ExternalLink size={12} />
+                </a>{" "}
+                in a new tab instead.
+              </p>
+              <p className="paperFooter">
+                If the file 404s, click "Compile draft" to build it.
+              </p>
+            </div>
+          </object>
+        </div>
+      )}
 
       {saveError && <div className="dialogError">{saveError}</div>}
       {compileResult && (
@@ -151,7 +203,7 @@ export function PaperEditor({ projectId, isRunning }: Props) {
           </button>
           <button
             className="primaryButton"
-            disabled={!dirty || saving || isRunning}
+            disabled={!dirty || saving || isRunning || view !== "source"}
             onClick={handleSave}
           >
             <Save size={14} /> {saving ? "Saving..." : "Save"}

frontend/src/views/ProjectDetailView.tsx

@@ -85,9 +85,6 @@ export function ProjectDetailView({ projectId, onBack }: Props) {
         <button className={tab === "paper" ? "active" : ""} onClick={() => setTab("paper")}>
           <FileText size={14} /> Paper
         </button>
-        <button className={tab === "pdf" ? "active" : ""} onClick={() => setTab("pdf")}>
-          <Files size={14} /> PDF
-        </button>
         <button className={tab === "slides" ? "active" : ""} onClick={() => setTab("slides")}>
           <Monitor size={14} /> Slides
         </button>
@@ -149,9 +146,6 @@ export function ProjectDetailView({ projectId, onBack }: Props) {
         {tab === "paper" && (
           <PaperEditor projectId={projectId} isRunning={project.is_running} />
         )}
-        {tab === "pdf" && (
-          <PdfView projectId={projectId} iterationCount={project.iteration_count} />
-        )}
         {tab === "slides" && (
           <SlidesEditor projectId={projectId} isRunning={project.is_running} />
         )}

paper.tex

@@ -219,77 +219,35 @@ \section{Introduction}
 
 \section{Setup and Assumptions}
 
-\paragraph{1.} Smooth fields
-
-\paragraph{2.} Compact support
+\halfseedTODO[derive]{id="bootstrap-setup", what="Define notation and assumptions for this project.", needs="Writer prose grounded in current research material"}
 
 
 \section{Analytical Results}
 
-\subsection{Result 1}
-The variance scales as 1/D.
-
-\paragraph{Evidence.} computation
-
-\paragraph{Confidence.} 0.70
-
-
-
-\begin{equation*}
-\halfseedeq{\sigma^2 \sim 1/D}
-\end{equation*}
-\begin{equation*}
-\halfseedeq{D = 2^N}
 \end{equation*}
+\halfseedTODO[derive]{id="bootstrap-analytical", what="Write the analytical results section as integrated prose.", needs="Writer prose grounded in current research material"}
 
 
 \section{Numerical Investigations}
 
-\todo{No numerical artifacts have reached the paper yet.}
+\halfseedTODO[data]{id="bootstrap-numerical", what="Write the numerical investigations section as integrated prose.", needs="Writer prose grounded in current research material"}
 
 
 
 
 \section{Prior Art}
 
-\todo{Literature pass has not yet identified concrete prior work.}
+\halfseedTODO[derive]{id="bootstrap-literature", what="Survey relevant prior work and place this paper in context.", needs="Writer prose grounded in current literature artifacts"}
 
 
 \section{Discussion}
-The action variation closes.
-
-
-\subsection{Open risks}
-\begin{itemize}
-  \item Boundary terms not yet checked.
-\end{itemize}
 
-\subsection{Suggested next steps}
-\begin{itemize}
-  \item Implement the convergence check.
-\end{itemize}
+\halfseedTODO[derive]{id="bootstrap-discussion", what="Discuss implications, limitations, and open questions.", needs="Writer prose grounded in current research material"}
 
 
 % PI-LOCK DISCUSSION
 % (no human content under PI-LOCK id="pi-discussion" yet)
 
-\section*{Open Questions}
-No open \verb|\todo| items.
-
-
-\appendix
-\section{Supporting Artifacts}
-This appendix lists the structured research artifacts the iteration drew on,
-in case a reader wants to verify how the body of the paper was synthesized
-from internal claims.
-
-\paragraph{A-1 (analytical, conf 0.70).} The variance scales as 1/D.
-\textit{Evidence:} computation.
-
-
-
-
-
 \bibliographystyle{plain}
 % Bibliography is generated by the citation gate; see citations.bib once enabled.
 

src/halfseed/publish/paper_edits.py

@@ -189,9 +189,35 @@ class _EditFailure(RuntimeError):
 # so the placeholder stays visible until real content arrives.
 MIN_REPLACE_PLACEHOLDER_CHARS = 80
 
+# Guard against the LLM "wiping a section with a placeholder macro" anti-
+# pattern: replace_section text='\\halfseedTODO{X pending}' as the entire
+# new body. That destroys the section's existing placeholder (with its id)
+# and replaces it with a no-id placeholder shell. The right move when a
+# section has no content yet is NO EDIT — leave the existing TODO alone.
+_PLACEHOLDER_SHELL_RE = re.compile(
+    r"^\s*\\halfseedTODO[^a-zA-Z]",
+    re.IGNORECASE,
+)
+
 
 def _dispatch(text: str, edit: PaperEdit) -> tuple[str, str]:
     if edit.op == "replace_section":
+        body = edit.text.strip()
+        if not body:
+            raise _EditFailure(
+                "replace_section rejected: empty body. If the section has "
+                "nothing to update, simply emit no edit for it (the "
+                "existing skeleton placeholder will remain)."
+            )
+        if _PLACEHOLDER_SHELL_RE.match(body) and len(body) < 200:
+            raise _EditFailure(
+                "replace_section rejected: body is just a \\halfseedTODO "
+                "macro shell. Replacing a section with a bare TODO macro "
+                "wipes the section's existing placeholder ID and content. "
+                "If the section's content is genuinely not ready, emit no "
+                "edit — the skeleton placeholder is already present. To "
+                "ADD a new placeholder use op=add_placeholder."
+            )
         return _replace_section(text, edit.section, edit.text)
     if edit.op == "append_to_section":
         return _append_to_section(text, edit.section, edit.text)
@@ -425,8 +451,14 @@ def _insert_after_section(
 
 def _set_command(text: str, command: str, new_value: str) -> tuple[str, str]:
     pattern = re.compile(rf"{command}\s*\{{[^{{}}]*\}}", re.DOTALL)
-    replacement = f"{command.replace(chr(92) * 2, chr(92))}" + "{" + new_value.strip() + "}"
-    new_text, count = pattern.subn(replacement, text, count=1)
+    # Build the replacement as a literal string. We pass it through
+    # pattern.sub via a lambda — using the string directly would cause
+    # `re` to interpret backslash escapes (`\h`, `\1`, ...) inside the
+    # LLM-supplied new_value, which is regex-syntax we DO NOT want here.
+    final = (
+        command.replace(chr(92) * 2, chr(92)) + "{" + new_value.strip() + "}"
+    )
+    new_text, count = pattern.subn(lambda _m: final, text, count=1)
     if count == 0:
         raise _EditFailure(f"{command} not found in document")
     return new_text, f"set {command} to {new_value!r}"
@@ -438,7 +470,12 @@ def _replace_environment(text: str, env: str, new_body: str) -> tuple[str, str]:
         re.DOTALL,
     )
     body = "\n" + new_body.strip("\n") + "\n"
-    new_text, count = pattern.subn(rf"\1{body}\3", text, count=1)
+    # Same regex-interprets-backslash trap as _set_command above. We
+    # capture begin/end via groups (\1, \3) but the body must be literal,
+    # so build the full replacement string and lambda it through.
+    def _mk(m: re.Match[str]) -> str:
+        return m.group(1) + body + m.group(3)
+    new_text, count = pattern.subn(_mk, text, count=1)
     if count == 0:
         raise _EditFailure(f"environment {env!r} not found")
     return new_text, f"replaced \\begin{{{env}}}...\\end{{{env}}} body"

src/halfseed/server/routes/paper.py

@@ -104,11 +104,19 @@ def get_paper_pdf(
                 "gate enabled (and latexmk installed) to produce it."
             ),
         )
+    # Serve INLINE so the browser's native PDF viewer renders inside the
+    # app's <object> embed instead of triggering a download. Passing
+    # FastAPI's `filename=` kwarg sets Content-Disposition=attachment,
+    # which is why the previous build forced a download every time the
+    # user clicked the PDF tab. The user can still save explicitly via
+    # right-click → Save As / Cmd-S.
     return FileResponse(
         pdf_path,
         media_type="application/pdf",
-        filename="paper.pdf",
-        headers={"Cache-Control": "no-store"},
+        headers={
+            "Cache-Control": "no-store",
+            "Content-Disposition": 'inline; filename="paper.pdf"',
+        },
     )
 
 

src/halfseed/server/routes/slides.py

@@ -101,9 +101,13 @@ def get_slides_pdf(
                 "(latexmk + xelatex must be installed)."
             ),
         )
+    # Inline rendering — see paper.py get_paper_pdf for why we don't pass
+    # FastAPI's filename= kwarg (it forces Content-Disposition=attachment).
     return FileResponse(
         pdf_path,
         media_type="application/pdf",
-        filename="slides.pdf",
-        headers={"Cache-Control": "no-store"},
+        headers={
+            "Cache-Control": "no-store",
+            "Content-Disposition": 'inline; filename="slides.pdf"',
+        },
     )

src/halfseed/workflow.py

@@ -1416,6 +1416,18 @@ def _digest(items: list[ResearchArtifact], limit: int = 6) -> list[dict]:
             "   - The Numerical / Results section in particular almost "
             "always needs at least one `data` or `figure` placeholder unless "
             "a sandbox-produced figure already covers the claim.\n"
+            "   - ANTI-PATTERN, do NOT do this: emitting a replace_section "
+            "edit whose `text` is just a single \\halfseedTODO macro like "
+            "'\\halfseedTODO{Intro pending}'. If you have nothing to add to "
+            "a section, EMIT NO EDIT for that section — the existing "
+            "placeholder already in the paper is what should remain.\n"
+            "   - ANTI-PATTERN, do NOT do this: replace_section text='' or "
+            "text shorter than 100 chars of real prose — that's wiping a "
+            "section's content with empty noise. Use replace_placeholder "
+            "(filling) or no edit (leaving the existing placeholder).\n"
+            "   - ANTI-PATTERN, do NOT use set_title / set_abstract to put "
+            "a \\halfseedTODO macro in the title or abstract. The skeleton "
+            "already has placeholder TODOs there; leave them.\n"
             "4. NOTES (% [HALFSEED-NOTE: kind] ... blocks) are LaTeX comments "
             "INVISIBLE to readers; use them to record blockers, decisions in "
             "flight, 'tried X but Y' rationale. Do NOT put project-status "

tests/test_paper_edits.py

@@ -298,3 +298,31 @@ def test_set_abstract_replaces_inside_environment() -> None:
     assert "A fresh abstract." in new_text
     assert "\\begin{abstract}" in new_text
     assert "\\end{abstract}" in new_text
+
+
+def test_set_title_with_backslash_text_does_not_crash() -> None:
+    """Regression: an LLM-supplied title containing backslash escapes
+    (e.g. '\\halfseedTODO{...}') must not be interpreted as regex
+    syntax by _set_command. The historic bug was a re.PatternError
+    'bad escape \\h' which crashed the whole iteration."""
+    edit = PaperEdit(
+        op="set_title",
+        text="\\halfseedTODO[human]{id=\"title\", what=\"Title pending\"}",
+    )
+    new_text, report = apply_edits(SAMPLE_PAPER, [edit])
+    assert report.applied == 1
+    assert "\\halfseedTODO" in new_text
+    assert "Title pending" in new_text
+
+
+def test_set_abstract_with_backslash_text_does_not_crash() -> None:
+    """Same regression as test_set_title_with_backslash_text_does_not_crash
+    but for set_abstract / _replace_environment."""
+    edit = PaperEdit(
+        op="set_abstract",
+        text="\\halfseedTODO{Abstract pending} — see Director's plan for round 2.",
+    )
+    new_text, report = apply_edits(SAMPLE_PAPER, [edit])
+    assert report.applied == 1
+    assert "\\halfseedTODO" in new_text
+    assert "Old abstract." not in new_text