Keypress not registering correctly when using LayerTap

[jakoritarleite]

I am facing an issue similar to the scenario 2 in the issue #496, where I have a key defined to LT1(KC_SPACE), and when I'm typing fast the KC_SPACE of the tap is sent after the key I press after pressing KC_SPACE.

For example, if I want to type " ff", it gets registered as "f f" instead, this is happening as I am writing this issue, sometimes I'll add a space between words, and the first letter of the next word stays behind the space, like ("somethingl iket his").

Another issue that is somewhat related, is that just like the tap seems a bit off the hold also feels weird, when I want to press something on Layer 1 by holding the space key, the first key pressed after holding is not the one on the layer, like:

KC_F is on layer 0, and KC_MINUS is on layer 1. I activate layer 1 by holding LT1(KC_SPACE).

Hold LT1(KC_SPACE) > press KC_F (KC_MINUS on layer 1) > press KC_F (KC_MINUS). The expected output is "--", but for some reason I get "f-".

[jakoritarleite]

I don't know why, but the async_matrix feature fixes this, I'll try to investigate it further to know why.

[HaoboGu]

interesting, do you have any logs when the key was misfired?

[chcbaram]

I have the same issue. I have a problem when using with LT()
The key right after LT() was not released so the key was released after pressing another key.
It will continue pressed even if the key was released.

[tompre]

I don't know why, but the async_matrix feature fixes this, I'll try to investigate it further to know why.

I changed the algorithm of the matrix in #630 but the change did only affect the behavior with async_matrix enabled.

Does this problem also happen with versions before #630 ? E.g.: 011a441

[chcbaram]

@tompre

I build the firmware in cloud.
I didn't have local build env.
So I cann't test previous version.

Is it possible to build precious version in cloud?

[jakoritarleite]

I am currently on revision 962a64b of RMK without async_matrix feature and the issue doesn't happen when I have permissive_hold active on QMK settings inside Vial, but as soon as I deactivate it the issue comes back.

Just noticed that even with async_matrix turned on I can reproduce the issue when permissive_hold is deactivated, I don't know why but in my Linux machine Vial didn't show the permissive_hold toggle at all, I need to open it in my Mac to be able to change it. Maybe in the end the issue was just the permissive hold, but I will continue to investigate further as I don't think it should happen..

I am sorry for not being active in the issue in the last week, just could not find time to work on this.

[HaoboGu]

Your first issue looks like that you have key rolling of LT(KC_SPACE) and f, in default mode, the LT1(KC_SPACE) is resolved when it timeouts or gets released. Maybe that's why you feel it wrong

[alxzh]

I ran into the same issue, flow tap + permissive hold fixed this for me.