chore: DevKit compliance -- golangci-lint v2, LICENSE, pre-push hook (#50)

* chore: DevKit compliance -- golangci-lint v2, LICENSE, pre-push hook

- Migrate .golangci.yml from v1 to v2 format
- Add missing linters from DevKit standard (misspell, bodyclose, noctx, etc.)
- Move gofmt/goimports to formatters section (v2 requirement)
- Remove gosimple (merged into staticcheck in v2)
- Add MIT LICENSE
- Add pre-push hook with Go build, test, lint, and markdownlint checks

Note: 24 pre-existing lint issues from new linters (exhaustive, gosec G602/G115,
prealloc, staticcheck QF) to be addressed in a follow-up PR.

Co-Authored-By: Claude <noreply@anthropic.com>

* fix: upgrade golangci-lint-action v6 -> v7 for v2 config support

Action v6 rejects golangci-lint v2 config fields (version, formatters,
linters.settings). Action v7 is required for v2 compatibility.
Also removes install-mode: goinstall which doesn't work with v2.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: HerbHall

.github/workflows/ci.yml

@@ -24,7 +24,6 @@ jobs:
       - uses: actions/setup-go@v5
         with:
           go-version-file: go.mod
-      - uses: golangci/golangci-lint-action@v6
+      - uses: golangci/golangci-lint-action@v7
         with:
-          version: v1.64.8
-          install-mode: goinstall
+          version: v2.10.1

.golangci.yml

@@ -1,35 +1,50 @@
+version: "2"
+
 run:
   timeout: 5m
 
 linters:
   enable:
-    - govet
     - errcheck
+    - gosec
+    - gocritic
+    - govet
     - staticcheck
-    - unused
-    - gosimple
     - ineffassign
-    - gocritic
-    - gofmt
-    - goimports
-    - gosec
+    - unused
+    - misspell
+    - bodyclose
+    - noctx
+    - durationcheck
+    - exhaustive
+    - nilerr
     - prealloc
+  settings:
+    gosec:
+      excludes:
+        - G104  # Unhandled errors on deferred Close -- acceptable in tests
+        - G404  # math/rand is correct for games, not security code
+        - G101  # false positives on non-credential constants
+    gocritic:
+      enabled-tags:
+        - diagnostic
+        - style
+        - performance
+      disabled-checks:
+        - hugeParam  # Bubbletea tea.Model requires value receivers
+    exhaustive:
+      default-signifies-exhaustive: true
+  exclusions:
+    rules:
+      - path: _test\.go
+        linters:
+          - gosec
+          - errcheck
+      - path: cmd/
+        linters:
+          - noctx
 
-linters-settings:
-  gocritic:
-    enabled-tags:
-      - diagnostic
-      - style
-      - performance
-    disabled-checks:
-      - hugeParam  # Bubbletea tea.Model requires value receivers
-  gosec:
-    excludes:
-      - G104  # unhandled errors on deferred Close()
-      - G404  # math/rand is correct for games, not security code
-      - G101  # false positives on non-credential constants
-
-issues:
-  exclude-use-default: false
-  max-issues-per-linter: 0
-  max-same-issues: 0
+formatters:
+  enable:
+    - gofmt
+    - goimports

LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2026 Herb Hall
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

scripts/pre-push

@@ -0,0 +1,19 @@
+#!/usr/bin/env bash
+# Pre-push hook: runs the same checks as CI before allowing a push.
+set -euo pipefail
+
+echo "==> pre-push: running CI checks..."
+
+echo "--- go build"
+go build ./...
+
+echo "--- go test"
+go test ./...
+
+echo "--- golangci-lint"
+go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.10.1 run ./...
+
+echo "--- markdownlint"
+npx --yes markdownlint-cli2 "**/*.md" "#node_modules"
+
+echo "==> pre-push: all checks passed"