Skip to content

Commit d7d1c86

Browse files
authored
Fix checking if value is provided (#434)
2 parents dbf7f75 + 132525e commit d7d1c86

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

publicdb/api/views.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -156,13 +156,13 @@ def stations(request, subcluster_number=None):
156156
of each station (matching the subcluster).
157157
158158
"""
159-
if subcluster_number:
159+
if subcluster_number is None:
160+
subcluster = None
161+
else:
160162
try:
161163
subcluster = Cluster.objects.get(number=subcluster_number)
162164
except Cluster.DoesNotExist:
163165
return HttpResponseNotFound()
164-
else:
165-
subcluster = None
166166

167167
stations = get_station_dict(subcluster=subcluster)
168168

@@ -229,13 +229,13 @@ def subclusters(request, cluster_number=None):
229229
subclusters that matched the given parameters.
230230
231231
"""
232-
if cluster_number:
232+
if cluster_number is None:
233+
cluster = None
234+
else:
233235
try:
234236
cluster = Cluster.objects.get(number=cluster_number, parent=None)
235237
except Cluster.DoesNotExist:
236238
return HttpResponseNotFound()
237-
else:
238-
cluster = None
239239

240240
subclusters = get_subcluster_dict(cluster=cluster)
241241

@@ -255,13 +255,13 @@ def clusters(request, country_number=None):
255255
clusters that matched the given parameters.
256256
257257
"""
258-
if country_number:
258+
if country_number is None:
259+
country = None
260+
else:
259261
try:
260262
country = Country.objects.get(number=country_number)
261263
except Country.DoesNotExist:
262264
return HttpResponseNotFound()
263-
else:
264-
country = None
265265

266266
clusters = get_cluster_dict(country=country)
267267

0 commit comments

Comments
 (0)