rubocops/text: Prefer lib/"string" over lib+"string"
#36283
issyl0tests.yml
on: pull_request
syntax
1m 50s
tap syntax
4m 56s
formula audit
5m 44s
cask audit
1m 47s
vendored gems
48s
Matrix: analytics
Matrix: bundle-and-services
Matrix: test-bot
Matrix: tests
Matrix: update-test
Annotations
13 errors
|
tap syntax
Process completed with exit code 1.
|
|
analytics (macOS)
Canceling since a higher priority waiting request for refs/pull/20235/merge exists
|
|
tests (Linux)
The operation was canceled.
|
|
tests (Linux):
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test/rubocops/text_spec.rb#L234
RuboCop::Cop::FormulaAudit::Text when auditing formula text reports an offense if `prefix + "bin"` is present
Failure/Error:
expect_offense(<<~RUBY)
class Foo < Formula
def install
ohai prefix + "bin"
^^^^^^^^^^^^^^ FormulaAudit/Text: Use `bin` instead of `prefix + "bin"`
end
end
RUBY
Diff:
@@ -1,6 +1,6 @@
class Foo < Formula
def install
ohai prefix + "bin"
- ^^^^^^^^^^^^^^ FormulaAudit/Text: Use `bin` instead of `prefix + "bin"`
+ ^^^^^^^^^^^^^^ FormulaAudit/Text: Use `prefix/"bin"` instead of `prefix + "bin"`
end
end
|
|
tests (Linux)
Canceling since a higher priority waiting request for refs/pull/20235/merge exists
|
|
tests (macOS)
The operation was canceled.
|
|
tests (macOS)
Canceling since a higher priority waiting request for refs/pull/20235/merge exists
|
|
tests (generic OS)
The operation was canceled.
|
|
tests (generic OS):
/home/linuxbrew/.linuxbrew/Homebrew/Library/Homebrew/test/rubocops/text_spec.rb#L234
RuboCop::Cop::FormulaAudit::Text when auditing formula text reports an offense if `prefix + "bin"` is present
Failure/Error:
expect_offense(<<~RUBY)
class Foo < Formula
def install
ohai prefix + "bin"
^^^^^^^^^^^^^^ FormulaAudit/Text: Use `bin` instead of `prefix + "bin"`
end
end
RUBY
Diff:
@@ -1,6 +1,6 @@
class Foo < Formula
def install
ohai prefix + "bin"
- ^^^^^^^^^^^^^^ FormulaAudit/Text: Use `bin` instead of `prefix + "bin"`
+ ^^^^^^^^^^^^^^ FormulaAudit/Text: Use `prefix/"bin"` instead of `prefix + "bin"`
end
end
|
|
tests (generic OS)
Canceling since a higher priority waiting request for refs/pull/20235/merge exists
|
|
tests (online)
The operation was canceled.
|
|
tests (online)
Canceling since a higher priority waiting request for refs/pull/20235/merge exists
|
|
CI
Canceling since a higher priority waiting request for refs/pull/20235/merge exists
|