Skip to content

Commit 3bec117

Browse files
authored
Merge pull request #20286 from Homebrew/enable_signing_audit
cask/audit: always enable codesign audit
2 parents dea25ec + 9dc5929 commit 3bec117

1 file changed

Lines changed: 14 additions & 2 deletions

File tree

Library/Homebrew/cask/audit.rb

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -486,7 +486,13 @@ def audit_livecheck_unneeded_long_version
486486

487487
sig { void }
488488
def audit_signing
489-
return if !signing? || download.blank? || (url = cask.url).nil?
489+
return if download.blank?
490+
491+
url = cask.url
492+
return if url.nil?
493+
494+
return if !cask.tap.official? && !signing?
495+
return if cask.deprecated? && cask.deprecation_reason != :unsigned
490496

491497
odebug "Auditing signing"
492498

@@ -511,9 +517,15 @@ def audit_signing
511517
add_error "Unknown artifact type: #{artifact.class}", location: url.location
512518
end
513519

520+
if result.success? && cask.deprecated? && cask.deprecation_reason == :unsigned
521+
add_error "Cask is deprecated as unsigned but artifacts are signed!"
522+
end
523+
524+
next if cask.deprecated? && cask.deprecation_reason == :unsigned
525+
514526
next if result.success?
515527

516-
add_error <<~EOS, location: url.location, strict_only: true
528+
add_error <<~EOS, location: url.location
517529
Signature verification failed:
518530
#{result.merged_output}
519531
macOS on ARM requires software to be signed.

0 commit comments

Comments
 (0)