caveats: skip shadow check when the queried formula has no installed keg

Author: HaraldNordgren

Library/Homebrew/caveats.rb

@@ -128,6 +128,7 @@ def keg_only_text(skip_reason: false)
   sig { returns(T.nilable(String)) }
   def shadowed_path_text
     return if Homebrew::EnvConfig.no_path_shadow_check?
+    return unless formula.any_version_installed?
 
     shadowed = shadowed_executables
     shadowed = shadowed.select { |_, shadower| sibling_keg_name(shadower) } if formula.keg_only? && !formula.linked?

Library/Homebrew/test/caveats_spec.rb

@@ -250,6 +250,7 @@ def caveats
         Pathname.new(f.opt_bin).mkpath
         FileUtils.touch(f.opt_bin/"foo")
         FileUtils.chmod(0755, f.opt_bin/"foo")
+        allow(f).to receive(:any_version_installed?).and_return(true)
         allow_any_instance_of(Object).to receive(:which).and_call_original
       end
 
@@ -291,6 +292,29 @@ def caveats
         expect(described_class.new(keg_only_f).caveats).not_to include("shadowed")
       end
 
+      it "does not warn when the queried formula itself is not installed" do
+        uninstalled_f = formula("foo@old") do
+          url "foo-1.0"
+          keg_only :versioned_formula
+        end
+        Pathname.new(uninstalled_f.opt_bin).mkpath
+        FileUtils.touch(uninstalled_f.opt_bin/"foo")
+        FileUtils.chmod(0755, uninstalled_f.opt_bin/"foo")
+
+        sibling_keg_bin = HOMEBREW_CELLAR/"foo@2.0/2.0/bin"
+        sibling_keg_bin.mkpath
+        sibling_shadower = sibling_keg_bin/"foo"
+        sibling_shadower.write("#!/bin/sh\n")
+        sibling_shadower.chmod(0755)
+
+        allow(uninstalled_f).to receive_messages(versioned_formulae_names: ["foo@2.0"],
+                                                 unversioned_formula_name: "foo",
+                                                 any_version_installed?:   false)
+        allow_any_instance_of(Object).to receive(:which).with("foo", ORIGINAL_PATHS).and_return(sibling_shadower)
+
+        expect(described_class.new(uninstalled_f).caveats).not_to include("shadowed")
+      end
+
       it "warns for a keg-only formula when a sibling keg is linked over it" do
         keg_only_f = formula("foo@1.0") do
           url "foo-1.0"
@@ -307,7 +331,8 @@ def caveats
         sibling_shadower.chmod(0755)
 
         allow(keg_only_f).to receive_messages(versioned_formulae_names: ["foo@2.0"],
-                                              unversioned_formula_name: "foo")
+                                              unversioned_formula_name: "foo",
+                                              any_version_installed?:   true)
         allow_any_instance_of(Object).to receive(:which).with("foo", ORIGINAL_PATHS).and_return(sibling_shadower)
 
         caveats = described_class.new(keg_only_f).caveats
@@ -323,7 +348,7 @@ def caveats
         Pathname.new(keg_only_f.opt_bin).mkpath
         FileUtils.touch(keg_only_f.opt_bin/"foo")
         FileUtils.chmod(0755, keg_only_f.opt_bin/"foo")
-        allow(keg_only_f).to receive(:linked?).and_return(true)
+        allow(keg_only_f).to receive_messages(linked?: true, any_version_installed?: true)
         shadower = Pathname.new("/usr/local/bin/foo")
         allow_any_instance_of(Object).to receive(:which).with("foo", ORIGINAL_PATHS).and_return(shadower)
         allow(shadower).to receive(:realpath).and_return(shadower)