formulary: make no_autobump! reason a symbol when needed

[botantony]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

[MikeMcQuaid]

@botantony Can you fill out more details in the issue body and/or a comment e.g. how you noticed this, how this affects users as-is, etc.

[botantony]

This affects users who want to audit and use FromAPILoader formula loader. Right now, most formula loaders correctly distinguish whether no_autobump! uses a string or a symbol. I might've fixed it in the auditor by checking if the reason is a symbol there, but I decided to move it to the formulary class for consistency

Plus, this is the way FromAPILoader deals with deprecate!/disable! reasons (which is very similar to this case):

brew/Library/Homebrew/formulary.rb

Lines 346 to 354 in cf8d654

	if (deprecation_date = json_formula["deprecation_date"].presence)
	reason = DeprecateDisable.to_reason_string_or_symbol json_formula["deprecation_reason"], type: :formula
	deprecate! date: deprecation_date, because: reason
	end
	if (disable_date = json_formula["disable_date"].presence)
	reason = DeprecateDisable.to_reason_string_or_symbol json_formula["disable_reason"], type: :formula
	disable! date: disable_date, because: reason
	end

brew/Library/Homebrew/deprecate_disable.rb

Lines 119 to 129 in cf8d654

	sig { params(string: T.nilable(String), type: Symbol).returns(T.nilable(T.any(String, Symbol))) }
	def to_reason_string_or_symbol(string, type:)
	return if string.nil?
	if (type == :formula && FORMULA_DEPRECATE_DISABLE_REASONS.key?(string.to_sym)) ||
	(type == :cask && CASK_DEPRECATE_DISABLE_REASONS.key?(string.to_sym))
	return string.to_sym
	end
	string
	end

[MikeMcQuaid]

Ok, thanks for the PR and for explaining! In future: please fill out the issue body and check the boxes.