Skip to content

Commit c58e10d

Browse files
committed
CWMS-2566: Switch to Netbeans Lookup directly
Legacy hec-lookup does not work properly with Java 21. Most HEC Java 21 applications ship with lookup-compat to allow the old API to use the Netbeans library. Update CDA Client to directly use the nb library rather than relying on the compat lib. Also update to metrics 4.0.0 which uses netbeans lookup.
1 parent 9339266 commit c58e10d

5 files changed

Lines changed: 9 additions & 13 deletions

File tree

buildSrc/src/main/groovy/cwms-data-api-client.java-conventions.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ compileJava {
1212
}
1313

1414
dependencies {
15-
annotationProcessor(libs.service.annotations)
15+
annotationProcessor(libs.lookup)
1616

1717
testImplementation(libs.junit.api)
1818
testRuntimeOnly(libs.junit.engine)

cwms-http-client/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ dependencies {
4040
implementation(libs.jwt)
4141

4242
runtimeOnly(libs.metrics.codahale)
43-
annotationProcessor(libs.service.annotations)
4443

4544
testImplementation(libs.junit.api)
4645
testImplementation(platform(libs.okhttp.bom))

cwms-http-client/src/main/java/mil/army/usace/hec/cwms/http/client/CwmsHttpClientMetrics.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@
2424

2525
package mil.army.usace.hec.cwms.http.client;
2626

27-
import rma.util.lookup.Lookup;
28-
import rma.util.lookup.Lookups;
27+
import org.openide.util.Lookup;
28+
import org.openide.util.lookup.Lookups;
2929
import usace.metrics.services.Metrics;
3030
import usace.metrics.services.MetricsService;
3131
import usace.metrics.services.MetricsServiceProvider;

cwms-http-client/src/main/java/mil/army/usace/hec/cwms/http/client/CwmsHttpMetricsServiceProvider.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,9 @@
3232
import java.util.Properties;
3333
import java.util.logging.Level;
3434
import java.util.logging.Logger;
35-
import rma.services.annotations.ServiceProvider;
36-
import rma.util.lookup.Lookup;
35+
36+
import org.openide.util.Lookup;
37+
import org.openide.util.lookup.ServiceProvider;
3738
import usace.metrics.services.MetricsApp;
3839
import usace.metrics.services.MetricsService;
3940
import usace.metrics.services.MetricsServiceProvider;

gradle/libs.versions.toml

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
[versions]
22

33
#HEC Dependencies
4-
metrics = "2.0"
5-
service-annotations = "2.0.1"
6-
lookup = "2.0"
4+
metrics = "4.0.0"
75

86
#Third Party Dependencies
97
jackson = "2.17.2"
@@ -14,20 +12,17 @@ annotation-api = "3.0.0"
1412
swagger-codegen = "3.0.61"
1513
jwt = "4.4.0"
1614
okhttp = "4.12.0"
15+
lookup = "RELEASE280"
1716

1817
#Test Dependencies
1918
junit = "5.10.3"
2019
mockito = "5.12.0"
2120

2221
[libraries]
2322
#HEC Dependencies
24-
2523
metrics = { module = "mil.army.usace.hec:metrics-services", version.ref = "metrics" }
2624
metrics-codahale = { module = "mil.army.usace.hec:metrics-codahale", version.ref = "metrics" }
2725

28-
lookup = { module = "mil.army.usace.hec:lookup", version.ref = "lookup" }
29-
service-annotations = { module = "mil.army.usace.hec:service-annotations", version.ref = "service-annotations" }
30-
3126
#Third-Party
3227
jackson-databind = { module = "com.fasterxml.jackson.core:jackson-databind", version.ref = "jackson" }
3328
jackson-jsr310 = { module = "com.fasterxml.jackson.datatype:jackson-datatype-jsr310", version.ref = "jackson" }
@@ -44,6 +39,7 @@ okhttp-urlconnection = { module = "com.squareup.okhttp3:okhttp-urlconnection", v
4439
okhttp-logging = { module = "com.squareup.okhttp3:logging-interceptor", version.ref = "okhttp" }
4540
okhttp-bom = { module = "com.squareup.okhttp3:okhttp-bom", version.ref = "okhttp" }
4641
swagger-parser = { module = "io.swagger.parser.v3:swagger-parser-v3", version.ref = "swagger-parser"}
42+
lookup = { module = "org.netbeans.api:org-openide-util-lookup", version.ref = "lookup" }
4743

4844
#Test Dependencies
4945
junit-api = { module = "org.junit.jupiter:junit-jupiter-api", version.ref = "junit" }

0 commit comments

Comments
 (0)