fix some issues identified by cppcheck (#334)

Author: ktarbet

heclib/hecdss/hecdss.c

@@ -130,12 +130,15 @@ HECDSS_API int hec_dss_open(const char* filename, dss_file** dss)
     log_handle = stdout;
 
     int status = hec_dss_zopen(f->ifltab,filename);
-    if (status != 0)
+    if (status != 0) {
+      free(f);
       return status;
+    }
     int version = zgetVersion(f->ifltab);
     if (version != 7) {
         hec_dss_log_error("version is not supported.\nOnly version 7 DSS files are supported");
         zclose(f->ifltab);
+        free(f);
         return -700;
     }
     *dss = f;

heclib/heclib_c/src/Internal/copyFile.c

@@ -41,7 +41,7 @@
 int copyFile(long long *ifltab, int handleTo)
 {
 
-	int istat;
+	int istat = 0;
 	int ihandle;
 	int numberReads;
 	int numberInts;

heclib/heclib_c/src/Internal/powf_wrap.c

@@ -1,40 +1,40 @@
-/* only under gcc (Linux)*/
-#if defined(__GNUC__) && (__linux__)
-
-/* for glibc version */
-#include <features.h>
-#include <math.h> /* powf call */
- /* glibc redefined powf in 2.27, breaks compatibility with prior versions */
-#if (defined(__GLIBC__) && (__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 27)) || (defined(__GNUC__) && (__GNUC__ <= 10))
-
-/* 64 bit glibc powf was defined in 2.2.5 */
-#if __LP64__
-# define SYMVER "GLIBC_2.2.5"
-
-/* 32-bit glibc powf was defined in 2.0 */
-#else 
-# define SYMVER "GLIBC_2.0"
-
-/* endif Architecture check */
-#endif
-
-/* to replace the function with the old call */
-#define USE_OLD_SYM(F,V) __asm__(".symver " #F ", " #F "@" V)
-
-/* force powf to be from earlier compatible glibc */
-USE_OLD_SYM(powf,SYMVER);
-
-/* endif GLIBC >= 2.27 */
-#endif
-
-/* wrap the function requires gcc -Wl,--wrap=powf when linking */
-float __wrap_powf( float base, float exponent ) {
-  /* call into the supported version of powf */
-  return powf(base, exponent);
-}
-
-/* so gets reloaded if necessary */
-#undef _FEATURES_H
-
-/* endif gcc & linux */
-#endif
+/* only under gcc (Linux)*/
+#if defined(__GNUC__) && (__linux__)
+
+/* for glibc version */
+#include <features.h>
+#include <math.h> /* powf call */
+ /* glibc redefined powf in 2.27, breaks compatibility with prior versions */
+#if (defined(__GLIBC__) && (__GLIBC__ == 2) && (__GLIBC_MINOR__ >= 27)) || (defined(__GNUC__) && (__GNUC__ <= 10))
+
+/* 64 bit glibc powf was defined in 2.2.5 */
+#if __LP64__
+# define SYMVER "GLIBC_2.2.5"
+
+/* 32-bit glibc powf was defined in 2.0 */
+#else 
+# define SYMVER "GLIBC_2.0"
+
+/* endif Architecture check */
+#endif
+
+/* to replace the function with the old call */
+#define USE_OLD_SYM(F,V) __asm__(".symver " #F ", " #F "@" V)
+
+/* force powf to be from earlier compatible glibc */
+USE_OLD_SYM(powf,SYMVER);
+
+/* endif GLIBC >= 2.27 */
+#endif
+
+/* wrap the function requires gcc -Wl,--wrap=powf when linking */
+float __wrap_powf( float base, float exponent ) {
+  /* call into the supported version of powf */
+  return powf(base, exponent);
+}
+
+/* so gets reloaded if necessary */
+#undef _FEATURES_H
+
+/* endif gcc & linux */
+#endif

heclib/heclib_c/src/Internal/zopenInternal.c

@@ -93,7 +93,7 @@
  {
 	 int ihandle;
 	 int status;
-	 int status2;
+	 int status2 = 0;
 	 int fileExists;
 	 int permission;
 	 int size;

heclib/heclib_c/src/Internal/ztsStoreIrreg7.c

@@ -61,7 +61,7 @@ int ztsStoreIrreg7(long long *ifltab, zStructTimeSeries *tss, int storageFlag)
 {
 	int status;
 	int *values;
-	int valueSize;
+	int valueSize = 0;
 	int *profileDepths;
 	int profileDepthsSize;
 
@@ -77,7 +77,7 @@ int ztsStoreIrreg7(long long *ifltab, zStructTimeSeries *tss, int storageFlag)
 	int timeBaseToEnd;
 	int time;
 	int dataType;
-	int valueElementSize;
+	int valueElementSize = 0;
 	int profileDepthsNumber;
 	int timeGranularity;
 

heclib/heclib_c/src/Internal/ztsStoreReg7.c

@@ -59,7 +59,7 @@ int ztsStoreReg7(long long *ifltab, zStructTimeSeries *tss, int storageFlag)
 {
 	int status;
 	int *values;
-	int valueSize;
+	int valueSize = 0;
 	int *profileDepths;
 	int profileDepthsSize;
 	int julianBlockDate;
@@ -85,7 +85,7 @@ int ztsStoreReg7(long long *ifltab, zStructTimeSeries *tss, int storageFlag)
 
 	int internalHeader[INT_HEAD_SIZE];
 	int internalHeaderArraySize  = INT_HEAD_SIZE;
-	int valueElementSize;
+	int valueElementSize = 0;
 	int profileDepthsNumber;
 	int boolReadBlock;
 

heclib/heclib_c/src/Public/zanalyzeFile.c

@@ -62,7 +62,7 @@ int zanalyzeFile(long long *ifltab)
 	int countTotal;
 	int numberValid;
 	int numberDeleted;
-	int numberZeros;
+	int numberZeros = 0;
 	long long binAddress;
 	long long *pathnameBin;
 	long long infoAddress;

heclib/heclib_c/src/Public/ztextRetrieveToFile.c

@@ -89,6 +89,7 @@ int ztextRetrieveToFile(long long *ifltab, const char *pathname, const char *fil
 	}
 #endif
 	if (status != 0) {
+		fclose(textFileFP);
 		return zerrorProcessing(ifltab, DSS_FUNCTION_ztextRetrieve_ID,
 					zdssErrorCodes.UNABLE_TO_WRITE_FILE, status, 0,
 					zdssErrorSeverity.WARNING, pathname, filename);