Skip to content

Commit 32f45d5

Browse files
committed
Address review feedback: doc entrypoint shape and crate-rename helper paths
Apply the approving review's inline doc suggestions and the crate-rename cleanup: - integration-guide: describe directory-based entrypoint discovery (src/integrations/<id>/index.ts) instead of arbitrary .ts files, and point the Testlight key file at testlight/index.ts. - creative-processing: fix the generated bundle output directory to crates/trusted-server-js/dist (not lib/dist). - .claude helper commands/agents: replace remaining crates/js references with crates/trusted-server-js so local/agent verification helpers keep working after the crate rename.
1 parent 450d0f8 commit 32f45d5

11 files changed

Lines changed: 16 additions & 16 deletions

File tree

.claude/agents/build-validator.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ Validate that the project builds correctly across all targets.
3434

3535
5. **JS build**
3636
```bash
37-
cd crates/js/lib && node build-all.mjs
37+
cd crates/trusted-server-js/lib && node build-all.mjs
3838
```
3939

4040
## Output

.claude/agents/pr-creator.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ Before creating the PR, verify the branch is healthy:
2323
cargo fmt --all -- --check
2424
cargo clippy --workspace --all-targets --all-features -- -D warnings
2525
cargo test --workspace
26-
cd crates/js/lib && npx vitest run
27-
cd crates/js/lib && npm run format
26+
cd crates/trusted-server-js/lib && npx vitest run
27+
cd crates/trusted-server-js/lib && npm run format
2828
cd docs && npm run format
2929
```
3030

.claude/agents/pr-reviewer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ For each changed file, evaluate:
109109
- Are edge cases covered (empty input, max values, error paths)?
110110
- If config-derived regex/pattern compilation changed: are invalid enabled-config startup failures and explicit `enabled = false` bypass cases both covered?
111111
- Rust tests: `cargo test --workspace`
112-
- JS tests: `npx vitest run` in `crates/js/lib/`
112+
- JS tests: `npx vitest run` in `crates/trusted-server-js/lib/`
113113

114114
### 5. Classify findings
115115

.claude/agents/repo-explorer.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ This is a Rust workspace with three crates:
1313

1414
- `crates/trusted-server-core/` — core library (integrations, HTML processing, Edge Cookies, GDPR)
1515
- `crates/trusted-server-adapter-fastly/` — Fastly Compute entry point
16-
- `crates/js/` — TypeScript/JS build pipeline (per-integration IIFE bundles)
16+
- `crates/trusted-server-js/` — TypeScript/JS build pipeline (per-integration IIFE bundles)
1717

1818
Target: `wasm32-wasip1` (Fastly Compute)
1919

.claude/agents/verify-app.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,13 +31,13 @@ cargo test --workspace
3131
### 4. JS Tests
3232

3333
```bash
34-
cd crates/js/lib && npx vitest run
34+
cd crates/trusted-server-js/lib && npx vitest run
3535
```
3636

3737
### 5. JS Format
3838

3939
```bash
40-
cd crates/js/lib && npm run format
40+
cd crates/trusted-server-js/lib && npm run format
4141
```
4242

4343
### 6. Docs Format

.claude/commands/check-ci.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@ Run all CI checks locally, in order. Stop and report if any step fails.
33
1. `cargo fmt --all -- --check`
44
2. `cargo clippy --workspace --all-targets --all-features -- -D warnings`
55
3. `cargo test --workspace`
6-
4. `cd crates/js/lib && npx vitest run`
7-
5. `cd crates/js/lib && npm run format`
6+
4. `cd crates/trusted-server-js/lib && npx vitest run`
7+
5. `cd crates/trusted-server-js/lib && npm run format`
88
6. `cd docs && npm run format`
99

1010
Report a summary of all results when done.

.claude/commands/test-all.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ cargo test --workspace
77
Then run JS tests:
88

99
```bash
10-
cd crates/js/lib && npx vitest run
10+
cd crates/trusted-server-js/lib && npx vitest run
1111
```
1212

1313
Report results for both. If any test fails, investigate and suggest a fix.

.claude/commands/test-crate.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ cargo test -p $ARGUMENTS
1111
If $ARGUMENTS is "js" or "javascript", run:
1212

1313
```bash
14-
cd crates/js/lib && npx vitest run
14+
cd crates/trusted-server-js/lib && npx vitest run
1515
```
1616

1717
Report results and investigate any failures.

.claude/commands/verify.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ Full verification: build, test, and lint the entire project.
55
3. `cargo fmt --all -- --check`
66
4. `cargo clippy --workspace --all-targets --all-features -- -D warnings`
77
5. `cargo test --workspace`
8-
6. `cd crates/js/lib && npx vitest run`
9-
7. `cd crates/js/lib && npm run format`
8+
6. `cd crates/trusted-server-js/lib && npx vitest run`
9+
7. `cd crates/trusted-server-js/lib && npm run format`
1010
8. `cd docs && npm run format`
1111

1212
Report results for each step. Stop and investigate if any step fails.

docs/guide/creative-processing.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -744,7 +744,7 @@ IntegrationRegistration::builder("my_integration")
744744

745745
### Bundle Types
746746

747-
Each integration is built as a separate IIFE at compile time (`crates/trusted-server-js/lib/dist/`):
747+
Each integration is built as a separate IIFE at compile time (`crates/trusted-server-js/dist/`):
748748

749749
- `tsjs-core.js` — Core API (always included)
750750
- `tsjs-creative.js` — Creative click-guard and tracking

0 commit comments

Comments
 (0)