Polish route dispatch tests

Author: ChristianPavilonis

crates/trusted-server-adapter-fastly/src/route_tests.rs

@@ -173,21 +173,10 @@ fn create_test_settings_with(consent_store: Option<&str>, origin_url: &str) -> S
     settings
 }
 
-fn build_route_stack(
-    settings: &Settings,
-) -> (
-    trusted_server_core::auction::AuctionOrchestrator,
-    IntegrationRegistry,
-) {
+fn route_with_settings(settings: &Settings, req: Request) -> Option<Response> {
     let orchestrator = build_orchestrator(settings).expect("should build auction orchestrator");
     let integration_registry =
         IntegrationRegistry::new(settings).expect("should create integration registry");
-
-    (orchestrator, integration_registry)
-}
-
-fn route_with_settings(settings: &Settings, req: Request) -> Option<Response> {
-    let (orchestrator, integration_registry) = build_route_stack(settings);
     let runtime_services = test_runtime_services(&req);
 
     futures::executor::block_on(route_request(
@@ -241,9 +230,9 @@ fn static_tsjs_route_serves_unified_bundle() {
 }
 
 #[test]
-fn static_tsjs_route_returns_not_found_for_unknown_bundle() {
+fn static_tsjs_route_returns_not_found_for_unknown_tsjs_bundle() {
     let settings = create_test_settings();
-    let req = Request::get("https://test.com/static/tsjs=unknown.js");
+    let req = Request::get("https://test.com/static/tsjs=tsjs-doesnotexist.min.js");
 
     let resp = route_with_settings(&settings, req).expect("should route static tsjs request");