Skip to content

Commit aa10f27

Browse files
authored
Standardize IntegrationConfig trait imports (#196)
Remove the IntegrationConfigTrait alias from permutive, lockr, and testlight integration modules. Use IntegrationConfig directly without aliasing, matching the pattern in other integrations and improving code consistency and searchability. Trait aliasing is typically reserved for avoiding name collisions, which don't exist here. Resolves: #190
1 parent 73183e7 commit aa10f27

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

crates/common/src/integrations/lockr.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ use crate::integrations::{
2929
AttributeRewriteAction, IntegrationAttributeContext, IntegrationAttributeRewriter,
3030
IntegrationEndpoint, IntegrationProxy, IntegrationRegistration,
3131
};
32-
use crate::settings::{IntegrationConfig as IntegrationConfigTrait, Settings};
32+
use crate::settings::{IntegrationConfig, Settings};
3333

3434
const LOCKR_INTEGRATION_ID: &str = "lockr";
3535

@@ -75,7 +75,7 @@ pub struct LockrConfig {
7575
pub origin_override: Option<String>,
7676
}
7777

78-
impl IntegrationConfigTrait for LockrConfig {
78+
impl IntegrationConfig for LockrConfig {
7979
fn is_enabled(&self) -> bool {
8080
self.enabled
8181
}

crates/common/src/integrations/permutive.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ use crate::integrations::{
1818
AttributeRewriteAction, IntegrationAttributeContext, IntegrationAttributeRewriter,
1919
IntegrationEndpoint, IntegrationProxy, IntegrationRegistration,
2020
};
21-
use crate::settings::{IntegrationConfig as IntegrationConfigTrait, Settings};
21+
use crate::settings::{IntegrationConfig, Settings};
2222

2323
const PERMUTIVE_INTEGRATION_ID: &str = "permutive";
2424

@@ -61,7 +61,7 @@ pub struct PermutiveConfig {
6161
pub rewrite_sdk: bool,
6262
}
6363

64-
impl IntegrationConfigTrait for PermutiveConfig {
64+
impl IntegrationConfig for PermutiveConfig {
6565
fn is_enabled(&self) -> bool {
6666
self.enabled
6767
}

crates/common/src/integrations/testlight.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ use crate::integrations::{
1515
IntegrationEndpoint, IntegrationProxy, IntegrationRegistration,
1616
};
1717
use crate::proxy::{proxy_request, ProxyRequestConfig};
18-
use crate::settings::{IntegrationConfig as IntegrationConfigTrait, Settings};
18+
use crate::settings::{IntegrationConfig, Settings};
1919
use crate::synthetic::{generate_synthetic_id, get_or_generate_synthetic_id};
2020
use crate::tsjs;
2121

@@ -37,7 +37,7 @@ pub struct TestlightConfig {
3737
pub rewrite_scripts: bool,
3838
}
3939

40-
impl IntegrationConfigTrait for TestlightConfig {
40+
impl IntegrationConfig for TestlightConfig {
4141
fn is_enabled(&self) -> bool {
4242
self.enabled
4343
}

0 commit comments

Comments
 (0)