Defect generating PnP in latest release

[cyberreefguru]

Hello everyone - starting here before opening a bug report. I have all my PCBs in GitHub and use CI/CD pipeline to generate my gerbers, BOMs, etc. I recently ran a job and got super weird results. A lot of my parts on the panel were in the wrong place. Generally they were all backwards, or rotated 90 degrees.

After A LOT of debugging, I decided to roll back to the previous release and all the issues went away. All the parts were at the correct positions within the BOM and CPL file.

It seems Kicad 9.0.9 or Kibot 1.9 is not properly applying the variant rotation filter to the second board in a panel (I haven't tried with more than 2 boards). The non-panel version comes out fine, but the panel has rampant, seemingly random rotation problems.

When I change the CI script to use container: ghcr.io/inti-cmnb/kicad9_auto_full:latest I get errors. When I use container: ghcr.io/inti-cmnb/kicad9_auto_full:1.8.5 the errors do not manifest.

I have no clue if this is a Kicad issue, a Kibot issue, a Panelizer issue, or a PNP problem. I generate the PnP file the same way for the panel and non-panel:

  - name: 'create_pnp_jlc'
    comment: 'Generate JLC PnP File'
    run_by_default: false
    type: position
    dir: pnp
    options:
      output: '%f-jlc-cpl-%r.%x'
      format: CSV
      units: millimeters
      separate_files_for_front_and_back: false
      only_smd: false
      exclude_filter: 'exclude_common'
      variant: jlcpcb
      columns:
        - id: Ref
          name: Designator
        - id: PosX
          name: "Mid X"
        - id: PosY
          name: "Mid Y"
        - id: Side
          name: Layer
        - id: Rot
          name: Rotation

filters:
  - name: 'exclude_common'
    type: 'generic'
    comment: 'Excludes test points, logos, symbols, and fiducials'
    exclude_any:
      - column: Reference
        regex: '^TP[0-9]*'
      - column: Reference
        regex: '^FID'
      - column: Reference
        regex: '^LOGO'
      - column: Reference
        regex: '^KiKit_'
      - column: Reference
        regex: '^kibuzzard-'
      - column: Reference
        regex: '^SYM'
  - name: only_jlc_parts
    comment: 'Only parts with JLC (LCSC) code'
    type: generic
    include_only:
      - column: 'LCSC'
        regex: '^C\d+'
  - name: fix_rotation
    comment: 'Adjust rotation for JLC'
    type: rot_footprint
    rotations:
      - ["^QFN-28-1EP_6x6mm_P0.65mm_EP4.25x4.25mm", -90.0]
      - ["^QFN-28_4x4mm_P0.5mm", 0.0]
      - ["^JST_SH_SM02B-SRSS-TB_1x02-1MP_P1.00mm_Horizontal", 180.0]
      - ["^JST_SH_SM03B-SRSS-TB_1x03-1MP_P1.00mm_Horizontal", 180.0]
      - ["^JST_SH_SM04B-SRSS-TB_1x04-1MP_P1.00mm_Horizontal", 180.0]
      - ["^JST_SH_SM06B-SRSS-TB_1x06-1MP_P1.00mm_Horizontal", 180.0]
      - ["^JST_SH_SM08B-SRSS-TB_1x08-1MP_P1.00mm_Horizontal", 180.0]
      - ["^JST_SH_BM02B-SRSS-TB_1x02-1MP_P1.00mm_Vertical", 180.0]
      - ["^JST_SH_BM03B-SRSS-TB_1x03-1MP_P1.00mm_Vertical", 180.0]
      - ["^JST_SH_BM04B-SRSS-TB_1x04-1MP_P1.00mm_Vertical", 180.0]
      - ["^JST_SH_BM06B-SRSS-TB_1x06-1MP_P1.00mm_Vertical", 180.0]
      - ["^JST_SH_BM08B-SRSS-TB_1x08-1MP_P1.00mm_Vertical", 180.0]
      - ["^LED_WS2812B_PLCC4_5.0x5.0mm_P3.2mm", -90.0]
      - ["^LED_WS2812B-2020_PLCC4_2.0x2.0mm", 0.0]
      - ["^SOT-523", 180.0]
      - ["^SOT-666", -90.0]
      - ["^XF2M-1415-1A", 180.0]
      - ["^XF2C_1415-1A", 180.0]
      # - ["^TI_SO-", 270.0]
      # - ["^SO-", 270.0]
      # - ["^HTSSOP-", 270.0]
      # - ["^SSOP-", 270.0]
      # - ["^MSOP-", 270.0]
      # - ["^USB_C_Receptacle_Palconn", 180.0]
      - ["^SOTFL50P160X60", 270]
      - ["^SOP65P640X110-20N", -90]
      - ["^CP_Elec_6.3x7.7", 0]
      - ["^CP_Elec_6.3x5.4", 0]
      - ["^CP_Elec_5x5.4", 0]
      - ["^Bourns_TC33X_Vertical", -90]
      - ["^LTR-303ALS-01", -90]
      - ["^PinHeader_2x05_P1.27mm_Vertical",90]
      - ["^PinHeader_2x05_P1.27mm_Vertical_SMD",90]
    offsets:
      - ["^TO-252-2", "3.3,0"]
      - ["^Converter_ACDC_MeanWell_IRM-10-xx_THT", "-19.2, 5.5"]
      - ["^GCT_USB4105-GF-A", "0, -2.5"]
      - ["^ESP32-S3-WROOM-1-N4R2", "0, 3.65"]
      - ["^ESP32-S3-WROOM-1-N8R2", "0, 3.65"]
      - ["^ESP32-S3-WROOM-1-N16R2", "0, 3.65"]
      - ["^XF2C_1415-1A", "0, -0.37"]
      - ["^XF2M_1415-1A", "0, -0.37"]
      - ["^PinHeader_2x05_P1.27mm_Vertical","2.54,0.635"]
      - ["^PinHeader_2x05_P1.27mm_Vertical_SMD","2.54,0.635"]

All the files are open source if you want to troll through them:
https://github.com/crgmakes/module-current-detector

Has anyone seen this issue before or can validate it's problem beyond me?

-Tom

[set-soft]

Hi @cyberreefguru !
Please create a very simple example, one or two components, the exact config you are using and explain what you are expecting and what you are getting.

[cyberreefguru]

Done. Opened a ticket.
https://github.com/crgmakes/kibot-sample-project

[set-soft]

Please add the config file and a detailed explanation of what do you get and what do you expect to get.

Using the above mentioned config (which is incomplete), and guessing the panel output I get:

Designator,Mid X,Mid Y,Layer,Rotation
"C5",30.5750,-16.9375,top,0.0000
"C5",30.5750,-38.9375,top,0.0000
"J1",29.6000,-25.7875,top,-90.0000
"J1",29.6000,-47.7875,top,-90.0000
"J2",38.6000,-52.2875,top,0.0000
"J2",38.6000,-30.2875,top,0.0000
"SW2",30.5750,-41.8125,top,0.0000
"SW2",30.5750,-19.8125,top,0.0000
"U1",38.1000,-24.2875,top,0.0000
"U1",38.1000,-46.2875,top,0.0000

Here the rotations are the same for both panels.

[cyberreefguru]

Apologies, I thought I included the output. Using 9.0.9, J1 and J2 are rotated for the panel -- the first J1 is -90 but the second J1 is 90. Where as 9.0.7 returns the same rotation for each designator. See attached.

kibot-sample-panel-v0.1-jlc-cpl-v0.1-9.0.7.csv
kibot-sample-panel-v0.1-jlc-cpl-v0.1-9.0.9.csv

-Tom

[set-soft]

I can't reproduce it using 9.0.9.
I need the actual config file that generates the difference.

[cyberreefguru]

I updated the repo and the issue. Single repo generates good and bad outcomes by only modulating the version of the container (latest vs 1.8.5). Hopefully this will work for you.

-Tom

[set-soft]

Ok, with the full config I was able to reproduce the mixed rotations

[set-soft]

This issue is now fixed by d5db42e
Use the dev images until the next release

[cyberreefguru]

Many thanks - any idea when you will drop the next release? I'm assuming 1.9.0 is still affected? Looking to move to Kicad 10 but waiting for this fix.

[set-soft]

I think the next release will be in the next week