[KK][VE]MP4 video is discolored

[Makao1240]

VideoExport 2.0.3

Since version 2.0, videos output as MP4 have exhibited slight color discoloration.
This is likely because the color space is not specified, causing the color conversion from RGB to YUV to fail.

[Lusiocc]

Please use the bug template:
!!! Test if the bug is present in the latest release first !!!

Describe the bug
A clear and concise description of what the bug is.

Expected behavior
A clear and concise description of what you expected to happen.

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Screenshots
If applicable, add screenshots to help explain your problem.

Additional information
This information will make finding and fixing the bug much easier.

• OS: [e.g. Windows11, SteamOS (if on Linux also specify Wine/Proton version)]
• Exact plugin/release version that introduced this issue [e.g. v1.0.1, r12.1, Always existed]
• Upload your output_log.txt after triggering the issue (drag the file in here)
  You can find output_log in the game root directory. If the file does not exist, edit doorstop_config.ini and set redirect_output_log = true

[Lusiocc]

Critical information is missing like which capture mode was used (ScreenshotManager, Build-in, Reshade). Also screenshots of before/after would be helpful. Errors or for some things debug logs of output_log.txt would clear up things.

[Makao1240]

Sorry.
The detailed situation is as follows.

Screenshot

VE 1.8.0

VE 2.0.3

VideoExport Settings	Value
Capture Tool	ScreenshotManager
Codec	H.264
Use GPU-accelerated codec	Enabled (NVIDIA)
Quality	18
Encoding Preset	Quality
Rotation	None

OS: Windows11
Viewer: Firefox 147.0.3

Also, the result changes depending on whether ScreenshotManager's output is set to JPG or PNG.
The appearance during discoloration is identical to the image of VE2.0.3 shown above.

	PNG	JPG
Screenshot	〇	〇
VE 1.8.0	×	〇
VE 2.0.3	×	×

[Lusiocc]

Yea, i see it now. I will look into it. My guess is the same as yours from the look of it. Maybe some sort of color conversion calculation error. I whole channel misalignment would be way more noticeable.
comparing both screenshots result in that diff:
Channel distortion: RMSE
red: 1719.23 (0.0262337)
green: 2136.57 (0.032602)
blue: 1146.99 (0.017502)
all: 1716.22 (0.0261879)

[Lusiocc]

<=1.8 used EncodeToPNG on the textures, saved them to disk and then ran ffmpeg with the pngs. Now the RGBA data is piped to ffmpeg directly.
Doing this introduced gamma mismatches between the old and new system i will look whats the best approach to handle that missing gamma correction, but i already have an idea.