Skip to content

Commit dcda4e7

Browse files
TimOlivermeta-codesync[bot]
authored andcommitted
Replaced FBReportMustFix with IGFailAssert (#1653)
Summary: ## Changes in this pull request `FBReportMustFix` isn't recognized by the public version of IGListKit. It is wrapped by `IGFailAssert` to abstract error tracking between the public and private versions, and so this change was causing the GitHub repo to stop compiling. This diff makes the appropriate change and confirms the unit tests are passing again. ### Checklist - [x] All tests pass. Demo project builds and runs. - [x] I added tests, an experiment, or detailed why my change isn't tested. - [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes. - [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md) Pull Request resolved: #1653 Test Plan: Compiling again! {F1984942550} Differential Revision: D91551520 Pulled By: TimOliver fbshipit-source-id: bdc9f786092853252011c551ce6d214a01445c63
1 parent 358fe89 commit dcda4e7

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Source/IGListKit/IGListCollectionViewLayout.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ - (UICollectionViewLayoutAttributes *)layoutAttributesForItemAtIndexPath:(NSInde
301301
CGRect frame = _sectionData[indexPath.section].itemBounds[indexPath.item];
302302
// Avoid setting frames with nan values
303303
if (isnan(frame.origin.x) || isnan(frame.origin.y) || isnan(frame.size.width) || isnan(frame.size.height)) {
304-
FBReportMustFix(@"IGListCollectionViewLayout encountered nan frame values for indexPath %@. Original frame: %@", indexPath, NSStringFromCGRect(frame));
304+
IGFailAssert(@"IGListCollectionViewLayout encountered nan frame values for indexPath %@. Original frame: %@", indexPath, NSStringFromCGRect(frame));
305305
return nil;
306306
}
307307
attributes.frame = frame;

0 commit comments

Comments
 (0)