fix code base

Author: jhayniffy

backend/src/admin/admin-claims-export.service.spec.ts

@@ -7,7 +7,6 @@ import { Readable } from 'stream';
 describe('AdminClaimsExportService', () => {
   let service: AdminClaimsExportService;
   let prismaService: PrismaService;
-  let tenantContextService: TenantContextService;
 
   const mockClaim = {
     id: 1,
@@ -49,7 +48,6 @@ describe('AdminClaimsExportService', () => {
 
     service = module.get<AdminClaimsExportService>(AdminClaimsExportService);
     prismaService = module.get<PrismaService>(PrismaService);
-    tenantContextService = module.get<TenantContextService>(TenantContextService);
   });
 
   describe('CSV header generation', () => {

backend/src/admin/admin-claims-export.service.ts

@@ -50,9 +50,8 @@ export class AdminClaimsExportService {
    */
   createClaimsExportStream(params: ClaimsExportParams): Readable {
     const readable = new Readable();
-    let isFirstRow = true;
 
-    this.streamClaimsAsCSV(readable, params, isFirstRow)
+    this.streamClaimsAsCSV(readable, params)
       .catch((err) => {
         this.logger.error('Error streaming claims export', { err });
         readable.destroy(err);
@@ -64,7 +63,6 @@ export class AdminClaimsExportService {
   private async streamClaimsAsCSV(
     writable: Readable,
     params: ClaimsExportParams,
-    isFirstRow: boolean,
   ): Promise<void> {
     let cursor: number | undefined;
     let hasMore = true;
@@ -142,17 +140,18 @@ export class AdminClaimsExportService {
     const where = claimTenantWhere(tenantId, {});
 
     if (params.status) {
-      where.status = params.status.toUpperCase() as any;
+      where.status = params.status.toUpperCase() as Prisma.ClaimWhereInput['status'];
     }
 
     if (params.from || params.to) {
-      where.createdAt = {};
+      const createdAt: Prisma.DateTimeFilter = {};
       if (params.from) {
-        (where.createdAt as any).gte = new Date(params.from);
+        createdAt.gte = new Date(params.from);
       }
       if (params.to) {
-        (where.createdAt as any).lte = new Date(params.to);
+        createdAt.lte = new Date(params.to);
       }
+      where.createdAt = createdAt;
     }
 
     return where;

backend/src/admin/admin.controller.spec.ts

@@ -496,7 +496,7 @@ describe('Admin Role Guard Enforcement', () => {
   });
 
   describe('Admin Role Required', () => {
-    const makeGuardCtx = (minRole?: string) => ({
+    const makeGuardCtx = () => ({
       getHandler: () => ({}),
       getClass: () => ({}),
       getType: () => 'http',

backend/src/admin/admin.controller.ts

@@ -255,7 +255,7 @@ export class AdminController {
   @Get('governance/quorum/impact')
   @MinAdminRole('viewer')
   @ApiOperation({ summary: 'Preview impact of quorum change on active claims' })
-  async getQuorumImpact(@Query('bps') bps?: string, @Req() req?: AdminRequest) {
+  async getQuorumImpact(@Query('bps') bps?: string) {
     const targetBps = bps ? parseInt(bps, 10) : null;
     if (targetBps !== null && (isNaN(targetBps) || targetBps < 1 || targetBps > 10000)) {
       throw new BadRequestException('bps must be between 1 and 10000');
@@ -505,11 +505,11 @@ export class AdminController {
   @MinAdminRole('viewer')
   @ApiOperation({ summary: 'Streaming CSV export of claims with pagination (no memory load)' })
   async exportClaims(
+    @Req() req: AdminRequest,
+    @Res() res: Response,
     @Query('status') status?: string,
     @Query('from') from?: string,
     @Query('to') to?: string,
-    @Req() req: AdminRequest,
-    @Res() res: Response,
   ) {
     const admin = req.user?.walletAddress ?? 'unknown';
     const rateLimitKey = `admin_claims_export:${admin}`;
@@ -1021,7 +1021,7 @@ export class AdminController {
         message: 'SOLVENCY_SIMULATION_SOURCE_ACCOUNT is not set.',
       });
     }
-    return this.soroban.simulateGetEvidenceLimits({ sourceAccount: source });
+    return this.sorobanService.simulateGetEvidenceLimits({ sourceAccount: source });
   }
 
   /**
@@ -1048,7 +1048,7 @@ export class AdminController {
     if (min > max) {
       throw new BadRequestException('min must not exceed max');
     }
-    const result = await this.soroban.invokeAdminSetEvidenceLimits({ min, max });
+    const result = await this.sorobanService.invokeAdminSetEvidenceLimits({ min, max });
     const actor = req.user?.walletAddress ?? 'unknown';
     await this.auditService.write({
       actor,

backend/src/assets/allowed-assets-cache.service.ts

@@ -2,7 +2,6 @@ import { Injectable, Logger, Optional } from '@nestjs/common';
 import { ConfigService } from '@nestjs/config';
 import { RedisService } from '../cache/redis.service';
 import { MetricsService } from '../metrics/metrics.service';
-import type { AllowedAsset } from '@prisma/client';
 
 const DEFAULT_TTL_SECONDS = 300; // 5 minutes
 const KEY_PREFIX = 'assets:allowed';
@@ -27,15 +26,15 @@ export class AllowedAssetsCacheService {
     return `${KEY_PREFIX}:list`;
   }
 
-  async getOrCompute(compute: () => Promise<AllowedAsset[]>): Promise<AllowedAsset[]> {
+  async getOrCompute<T>(compute: () => Promise<T[]>): Promise<T[]> {
     const key = this.getCacheKey();
-    const cached = await this.redis.get<AllowedAsset[]>(key);
+    const cached = await this.redis.get<T[]>(key);
     if (cached) {
-      this.metrics?.recordCache('allowed_assets', 'hit');
+      this.metrics?.recordRedisCache('hit', 'allowed_assets');
       return cached;
     }
 
-    this.metrics?.recordCache('allowed_assets', 'miss');
+    this.metrics?.recordRedisCache('miss', 'allowed_assets');
     const result = await compute();
     await this.redis.set(key, result, this.ttlSeconds);
     return result;

backend/src/auth/token-blacklist.service.ts

@@ -18,7 +18,7 @@ export class TokenBlacklistService {
     }
 
     const key = TOKEN_BLACKLIST_PREFIX + jti;
-    await this.redis.client.setex(key, ttlSeconds, '1');
+    await this.redis.getClient().setex(key, ttlSeconds, '1');
   }
 
   /**
@@ -27,7 +27,7 @@ export class TokenBlacklistService {
    */
   async isBlacklisted(jti: string): Promise<boolean> {
     const key = TOKEN_BLACKLIST_PREFIX + jti;
-    const result = await this.redis.client.exists(key);
+    const result = await this.redis.getClient().exists(key);
     return result === 1;
   }
 

backend/src/auth/wallet-auth.service.ts

@@ -119,7 +119,7 @@ export class WalletAuthService {
         stored.message,
         signatureBase64,
       );
-    } catch (err) {
+    } catch {
       throw new UnauthorizedException({
         code: 'INVALID_SIGNATURE',
         message: 'Signature verification failed.',

backend/src/common/interceptors/transform.interceptor.ts

@@ -24,7 +24,11 @@ export class TransformInterceptor implements NestInterceptor {
 
         // Handle paginated responses with pagination field
         if (response && typeof response === 'object' && 'pagination' in response && 'data' in response) {
-          const { pagination, data, ...rest } = response as any;
+          const { pagination, data, ...rest } = response as {
+            pagination: { total: number; next_cursor?: unknown };
+            data: unknown;
+            [key: string]: unknown;
+          };
           return {
             data,
             meta: {

backend/src/experimental/xdr-decode.controller.spec.ts

@@ -40,16 +40,6 @@ describe('XdrDecodeController', () => {
     });
 
     it('should decode valid XDR ScVal', () => {
-      // Create a simple uint32 ScVal: value 42
-      const scVal = {
-        discriminant: 'scValTypeUint32',
-        uint32: { low: 42, high: 0, unsigned: true },
-        toXDR: function (encoding: string) {
-          // Return a buffer representation
-          return Buffer.from('AAAAAAA=', 'base64');
-        },
-      };
-
       // Mock the xdr module behavior
       // In a real test, this would use actual stellar-sdk XDR encoding
       const mockReq = {

backend/src/indexer/indexer.service.ts

@@ -104,6 +104,7 @@ export class IndexerService {
     @Optional() private readonly votePubSub?: VotePubSubService,
     @Optional() private readonly outboundWebhook?: OutboundWebhookService,
     @Optional() private readonly adminAnalytics?: AdminAnalyticsService,
+    @Optional() private readonly allowedAssetsCache?: AllowedAssetsCacheService,
   ) {
     this.networkId = this.config.get<string>('STELLAR_NETWORK', 'testnet');
     this.gapThresholdLedgers = this.config.get<number>('INDEXER_GAP_ALERT_THRESHOLD_LEDGERS', 100);
@@ -622,7 +623,7 @@ export class IndexerService {
     await this.allowedAssetsCache?.invalidateAll();
   }
 
-  private async handleAssetRemoved(tx: IndexerTx, data: EventPayload, event: SorobanEvent) {
+  private async handleAssetRemoved(tx: IndexerTx, data: EventPayload, _event: SorobanEvent) {
     const contractId = getStringValue(data.contract_id);
 
     await tx.allowedAsset.update({