Workaround update checker without json due to paper removal

Signed-off-by: Alexander Brandes <mc.cache@web.de>

Author: NotMyFault

build.gradle.kts

@@ -49,6 +49,16 @@ dependencies {
     implementation("org.bstats:bstats-bukkit")
     implementation("io.papermc:paperlib")
     implementation("com.intellectualsites.paster:Paster")
+
+    // Testing
+    testImplementation("org.junit.jupiter:junit-jupiter-api:5.10.0")
+    testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.10.0")
+    testImplementation("org.junit.platform:junit-platform-launcher:1.10.0")
+}
+
+// Enable JUnit Platform for tests
+tasks.test {
+    useJUnitPlatform()
 }
 
 tasks.compileJava.configure {

src/main/java/com/thevoxelbox/voxelsniper/VoxelSniperPlugin.java

@@ -18,6 +18,7 @@
 import com.thevoxelbox.voxelsniper.performer.PerformerRegistry;
 import com.thevoxelbox.voxelsniper.performer.property.PerformerProperties;
 import com.thevoxelbox.voxelsniper.sniper.SniperRegistry;
+import com.thevoxelbox.voxelsniper.update.UpdateCheckerParser;
 import com.thevoxelbox.voxelsniper.util.io.VoxelSniperResourceLoader;
 import io.papermc.lib.PaperLib;
 
@@ -30,9 +31,6 @@
 import org.bukkit.plugin.PluginManager;
 import org.bukkit.plugin.java.JavaPlugin;
 import org.incendo.serverlib.ServerLib;
-import org.json.simple.JSONArray;
-import org.json.simple.JSONObject;
-import org.json.simple.JSONValue;
 
 import java.io.BufferedReader;
 import java.io.File;
@@ -270,7 +268,8 @@ public CommandRegistry getCommandRegistry() {
         return this.commandRegistry;
     }
 
-    // Borrowed from Vault
+    // Borrowed from Vault - Updated to workaround JSON removal from paper
+
     private double updateCheck(double currentVersion) {
         try {
 
@@ -280,18 +279,26 @@ private double updateCheck(double currentVersion) {
             conn.addRequestProperty("User-Agent", "FastAsyncVoxelSniper Update Checker");
             conn.setDoOutput(true);
             final BufferedReader reader = new BufferedReader(new InputStreamReader(conn.getInputStream()));
-            final String response = reader.readLine();
-            final JSONArray array = (JSONArray) JSONValue.parse(response);
+            StringBuilder sb = new StringBuilder();
+            String line;
+            while ((line = reader.readLine()) != null) {
+                sb.append(line);
+            }
+            final String response = sb.toString();
+
+            // Extract last name using UpdateCheckerParser to avoid JSON dependency
+            String lastName = UpdateCheckerParser.extractLatestNameFromResponse(response);
 
-            if (array.isEmpty()) {
+            if (lastName == null) {
                 LOGGER.warn("No files found, or Feed URL is bad.");
                 return currentVersion;
             }
-            newVersionTitle =
-                    ((String) ((JSONObject) array.getLast()).get("name")).replace("FastAsyncVoxelSniper", "").trim();
+            newVersionTitle = lastName.replace("FastAsyncVoxelSniper", "").trim();
             return Double.parseDouble(newVersionTitle.replaceFirst("\\.", "").trim());
         } catch (IOException ignored) {
             LOGGER.error("Unable to connect to api.curseforge.com to check for updates. Improper firewall configuration?");
+        } catch (NumberFormatException e) {
+            LOGGER.warn("Unable to parse version string: {}", newVersionTitle, e);
         }
         return Double.NaN;
     }