Fixing count error by referencing error variable directly (#111)

nchiasson-dgi · dannylamb · commit 62d5c1c70698 · 2019-12-20T14:40:24.000-04:00
diff --git a/includes/bookmark.inc b/includes/bookmark.inc
@@ -944,7 +944,7 @@ abstract class Bookmark implements BookmarkInterface {
     }
 
     $errors = form_get_errors();
-    if (count($errors) === 0) {
+    if (!$errors) {
       $page = pager_default_initialize(
           $this->getPidCount(), variable_get('islandora_bookmark_detailed_page_elements', 10), $form_state['islandora_bookmark_pager_element']
       );
diff --git a/islandora_bookmark.module b/islandora_bookmark.module
@@ -1099,7 +1099,7 @@ function islandora_bookmark_add_form_submit(array $form, array &$form_state) {
 function islandora_bookmark_add_pid(array $form, array &$form_state) {
   $errors = form_get_errors();
 
-  if (count($errors) === 0) {
+  if (!$errors) {
     module_load_include('inc', 'islandora_bookmark', 'includes/api');
     $key = $form_state['values']['add_bookmarks'];
     $pid = $form_state['islandora_bookmark_pid'];

Original file line number	Diff line number	Diff line change
`@@ -944,7 +944,7 @@ abstract class Bookmark implements BookmarkInterface {`
`944`	`944`	`}`
`945`	`945`
`946`	`946`	`$errors = form_get_errors();`
`947`		`- if (count($errors) === 0) {`
	`947`	`+ if (!$errors) {`
`948`	`948`	`$page = pager_default_initialize(`
`949`	`949`	`$this->getPidCount(), variable_get('islandora_bookmark_detailed_page_elements', 10), $form_state['islandora_bookmark_pager_element']`
`950`	`950`	`);`