Question on compute_scan_angle

[chengdang]

@BenjaminRuston @BenjaminTJohnson

Looking at the compute_scan_angle

ioda-converters/src/pyiodaconv/def_jedi_utils.py

Line 77 in ddba910

def compute_scan_angle(instr_scan_ang, sensor_altitude, sensor_zenith, qc_flag=[None]):

I have a question: with

ioda-converters/src/pyiodaconv/def_jedi_utils.py

Line 90 in ddba910

# do we need a missing here

When sum(good) <= 0, or for non-good indices,ratio never gets assigned, which would bring a random value to scanang calculation.

Is this by design since it does not matter if QC is bad?

[chengdang]

Another question is with condition:

ioda-converters/src/pyiodaconv/def_jedi_utils.py

Line 94 in ddba910

if not qc_flag[0]:

If user do pass a valid qc_flag array to this function, for example, [0,1,1,1,1]. I assume it means it's bad QC except for the 1st element. But, with the current setup, qc_flag will be re-assigned as all good QC [0,0,0,0,0]. Is this also by design?

Still new to this QC flag so I'm wondering why it's set up like this.

[BenjaminRuston]

thanks @chengdang yes there is likely something to fix here

the desired behavior was for qcFlag to be optional and if passed it would only compute for Locations with qcFlag == 0; and the others should be populated with the float missing value