fix(upgrade): add --auto flag to upgrade command

Co-authored-by: JanDeDobbeleer <2492783+JanDeDobbeleer@users.noreply.github.com>

Author: Copilot

src/cli/upgrade.go

@@ -20,6 +20,7 @@ import (
 
 var (
 	force bool
+	auto  bool
 )
 
 // upgradeCmd represents the upgrade command
@@ -63,7 +64,8 @@ var upgradeCmd = &cobra.Command{
 
 		cache.Init(sh, cache.Persist)
 
-		if _, OK := cache.Get[string](cache.Device, upgrade.CACHEKEY); OK && !force {
+		// Only respect the cache interval when using --auto flag
+		if _, OK := cache.Get[string](cache.Device, upgrade.CACHEKEY); OK && auto {
 			log.Debug("upgrade check already performed recently, skipping")
 			return
 		}
@@ -76,7 +78,7 @@ var upgradeCmd = &cobra.Command{
 		defer func() {
 			fmt.Print(terminal.StopProgress())
 
-			// always reset the cache key so we respect the interval no matter what the outcome
+			// Set the cache key after any upgrade check to prevent redundant checks
 			cache.Set(cache.Device, upgrade.CACHEKEY, "true", cfg.Upgrade.Interval)
 
 			cache.Close()
@@ -144,6 +146,7 @@ func executeUpgrade(cfg *upgrade.Config) int {
 
 func init() {
 	upgradeCmd.Flags().BoolVarP(&force, "force", "f", false, "force the upgrade even if the version is up to date")
+	upgradeCmd.Flags().BoolVar(&auto, "auto", false, "respect the cache interval for automatic upgrades")
 	upgradeCmd.Flags().BoolVar(&debug, "debug", false, "enable/disable debug mode")
 	RootCmd.AddCommand(upgradeCmd)
 }

src/shell/bash_test.go

@@ -12,7 +12,7 @@ func TestBashFeatures(t *testing.T) {
 
 	want := `// these are the features
 _omp_ftcs_marks=1
-"$_omp_executable" upgrade
+"$_omp_executable" upgrade --auto
 "$_omp_executable" notice
 _omp_cursor_positioning=1`
 
@@ -33,7 +33,7 @@ bleopt prompt_ps1_final='$(
         --escape=false
 )'
 _omp_ftcs_marks=1
-"$_omp_executable" upgrade
+"$_omp_executable" upgrade --auto
 "$_omp_executable" notice
 bleopt prompt_rps1='$(
 	"$_omp_executable" print right \

src/shell/cmd.go

@@ -19,7 +19,7 @@ func (f Features) Cmd() Code {
 	case Tooltips:
 		return "enable_tooltips()"
 	case Upgrade:
-		return `os.execute(string.format('"%s" upgrade', omp_executable))`
+		return `os.execute(string.format('"%s" upgrade --auto', omp_executable))`
 	case Notice:
 		return `os.execute(string.format('"%s" notice', omp_executable))`
 	case PromptMark, PoshGit, Azure, LineError, Jobs, CursorPositioning, Async:

src/shell/cmd_test.go

@@ -14,7 +14,7 @@ func TestCmdFeatures(t *testing.T) {
 enable_tooltips()
 transient_enabled = true
 ftcs_marks_enabled = true
-os.execute(string.format('"%s" upgrade', omp_executable))
+os.execute(string.format('"%s" upgrade --auto', omp_executable))
 os.execute(string.format('"%s" notice', omp_executable))
 rprompt_enabled = true`
 

src/shell/code.go

@@ -11,7 +11,7 @@ type Code string
 const (
 	unixFTCSMarks         Code = "_omp_ftcs_marks=1"
 	unixCursorPositioning Code = "_omp_cursor_positioning=1"
-	unixUpgrade           Code = `"$_omp_executable" upgrade`
+	unixUpgrade           Code = `"$_omp_executable" upgrade --auto`
 	unixNotice            Code = `"$_omp_executable" notice`
 )
 

src/shell/elvish.go

@@ -10,7 +10,7 @@ var elvishInit string
 func (f Features) Elvish() Code {
 	switch f {
 	case Upgrade:
-		return "$_omp_executable upgrade"
+		return "$_omp_executable upgrade --auto"
 	case Notice:
 		return "$_omp_executable notice"
 	case PromptMark, RPrompt, PoshGit, Azure, LineError, Jobs, CursorPositioning, Tooltips, Transient, FTCSMarks, Async:

src/shell/elvish_test.go

@@ -10,7 +10,7 @@ func TestElvishFeatures(t *testing.T) {
 	got := allFeatures.Lines(ELVISH).String("// these are the features")
 
 	want := `// these are the features
-$_omp_executable upgrade
+$_omp_executable upgrade --auto
 $_omp_executable notice`
 
 	assert.Equal(t, want, got)

src/shell/fish_test.go

@@ -14,7 +14,7 @@ func TestFishFeatures(t *testing.T) {
 enable_poshtooltips
 set --global _omp_transient_prompt 1
 set --global _omp_ftcs_marks 1
-"$_omp_executable" upgrade
+"$_omp_executable" upgrade --auto
 "$_omp_executable" notice
 set --global _omp_prompt_mark 1`
 

src/shell/nu.go

@@ -14,7 +14,7 @@ func (f Features) Nu() Code {
 	case Transient:
 		return `$env.TRANSIENT_PROMPT_COMMAND = {|| _omp_get_prompt transient }`
 	case Upgrade:
-		return "^$_omp_executable upgrade"
+		return "^$_omp_executable upgrade --auto"
 	case Notice:
 		return "^$_omp_executable notice"
 	case PromptMark, RPrompt, PoshGit, Azure, LineError, Jobs, Tooltips, FTCSMarks, CursorPositioning, Async:

src/shell/nu_test.go

@@ -12,7 +12,7 @@ func TestNuFeatures(t *testing.T) {
 
 	want := `// these are the features
 $env.TRANSIENT_PROMPT_COMMAND = {|| _omp_get_prompt transient }
-^$_omp_executable upgrade
+^$_omp_executable upgrade --auto
 ^$_omp_executable notice`
 
 	assert.Equal(t, want, got)