VIM: Colors change after quitting

[roddolf]

Prerequisites

• I have read and understand the CONTRIBUTING guide
• I looked for duplicate issues before submitting this one

Description

When using vim and then exiting, the colors of the lines before using its change of tone (see image attached).

Environment

• Oh my Posh version: 3.51.0
• Theme: fish
• Operating System: Windows 10
• Shell: PowerShell 7.1.0
• Terminal: Windows Terminal Preview 1.5.3242.0

Steps to Reproduce

1. [First Step] open vim
2. [Second Step] exit vim

Expected behavior: [What you expected to happen]
The colors remain the same.

Actual behavior: [What actually happened]
The colors change on the lines before using vim

[JanDeDobbeleer]

@roddolf do you use the named 16 colors or hex colors?

[roddolf]

I'm using hex colors,
This is the schema set:

"schemes": [
    {
        "name": "Dark",
        "black": "#000000",
        "red": "#bb0000",
        "green": "#00bb00",
        "yellow": "#bbbb00",
        "blue": "#0000bb",
        "purple": "#bb00bb",
        "cyan": "#00bbbb",
        "white": "#bbbbbb",
        "brightBlack": "#555555",
        "brightRed": "#ff5555",
        "brightGreen": "#55ff55",
        "brightYellow": "#ffff55",
        "brightBlue": "#5555ff",
        "brightPurple": "#ff55ff",
        "brightCyan": "#55ffff",
        "brightWhite": "#ffffff",
        "background": "#070707",
        "foreground": "#bbbbbb"
    }
],

[JanDeDobbeleer]

@roddolf I assume the theme is the default fish theme?

[roddolf]

Yes, the buildin fish theme.

[JanDeDobbeleer]

I'll see if I can reproduce this, chances are it's a terminal issue.

[JanDeDobbeleer]

@roddolf I tested this on the following:

• MacOS - iTerm2: no visual changes
• Windows - ConEmu: no visual changes
• Windows - Windows Terminal: visual changes

It's safe to say this is a Windows Terminal issue. As the colors don't change magically (they are only read within Oh my Posh, not set/changed), you have to ask for assistance there. In my tests, it even changes the previously correctly rendered colors, meaning the terminal is the one in control here.

[JanDeDobbeleer]

@roddolf microsoft/terminal#3794 and vim/vim#5092 meaning this is indeed caused by VIM. I will move this to discussions as a way to keep track of it.