Skip to content

terraform-engineer: no explicit approval gate between plan and apply #211

Description

@specterslient95-lgtm

Problem

The skills/terraform-engineer/SKILL.md workflow says to run terraform plan -out=tfplan, review the output carefully, and then run terraform apply tfplan. It does not require explicit user approval between plan review and apply.

Impact

terraform apply can create, modify, or destroy infrastructure. A skill should not proceed from plan to apply without a clear approval checkpoint, especially when managing cloud resources.

Suggested fix

Add a required approval step after terraform plan and before terraform apply:

  1. Show a summarized plan with creates, updates, deletes, and any destructive actions.
  2. Ask for explicit user approval.
  3. Only run terraform apply tfplan after approval.
  4. Refuse apply if destructive changes are present and the user has not explicitly accepted them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions