Clean code (#11)

* cleanup domain models, components, integration tests,
* created Infra and Ports directories
* enabled removed .js extension in imports
* fixed eslint with .mjs extension

Author: JohLav

.gitignore

@@ -1,6 +1,6 @@
 node_modules/
 reports/
-build/
+dist/
 generated/prisma/
 
 ### JetBrains template

cucumber.js

@@ -0,0 +1,9 @@
+let common = [
+  "features/**/*.feature",
+  "--require-module ts-node/register",
+  "--require features/**/*.ts",
+].join(" ");
+
+module.exports = {
+  default: common,
+};

cucumber.json

@@ -1,10 +1,10 @@
 import eslint from "@eslint/js";
-import prettierConfig from "eslint-config-prettier";
 import tseslint from "typescript-eslint";
+import prettierConfig from "eslint-config-prettier";
 
 export default tseslint.config(
   {
-    ignores: ["build/**"],
+    ignores: ["dist/**", "node_modules/**", "**/*.js"],
   },
   eslint.configs.recommended,
   tseslint.configs.recommended,

eslint.config.js eslint.config.mjseslint.config.js renamed to eslint.config.mjs

@@ -1,10 +1,10 @@
 import { Given } from "@cucumber/cucumber";
-import { User } from "../../src/Domain/Models/User.js";
-import { Vehicle } from "../../src/Domain/Models/Vehicle.js";
-import { InMemoryFleetRepository } from "../../src/Secondary/Repositories/InMemoryFleetRepository.js";
-import { initializeFleetForUser } from "./shared/initializeFleetForUser.js";
-import { registerVehicleInUserFleet } from "./register_vehicle_steps.js";
-import { generateFrenchPlateNumber } from "../../tests/Utils/generateFrenchPlateNumber.js";
+import { User } from "../../src/Domain/Models/User";
+import { Vehicle } from "../../src/Domain/Models/Vehicle";
+import { InMemoryFleetRepository } from "../../src/Infra/Secondary/Repositories/InMemoryFleetRepository";
+import { initializeFleetForUser } from "./shared/initializeFleetForUser";
+import { registerVehicleInUserFleet } from "./register_vehicle_steps";
+import { generateFrenchPlateNumber } from "../../tests/Utils/generateFrenchPlateNumber";
 
 Given("my fleet", async function (): Promise<void> {
   const user: User = User.create(crypto.randomUUID());

features/steps/common_steps.ts

@@ -3,12 +3,12 @@ import { Given, Then, When } from "@cucumber/cucumber";
 import { expect } from "chai";
 
 // Second group: Domain
-import { Location } from "../../src/Domain/Models/Location.js";
-import { VehicleAlreadyParkedAtThisLocationError } from "../../src/Domain/Errors/VehicleAlreadyParkedAtThisLocationError.js";
+import { Location } from "../../src/Domain/Models/Location";
+import { VehicleAlreadyParkedAtThisLocationError } from "../../src/Domain/Errors/VehicleAlreadyParkedAtThisLocationError";
 
 // Third group: Helpers
-import { parkVehicleAtLocation } from "./shared/parkVehicleAtLocation.js";
-import { retrieveLocation } from "./shared/retrieveLocation.js";
+import { parkVehicleAtLocation } from "./shared/parkVehicleAtLocation";
+import { retrieveLocation } from "./shared/retrieveLocation";
 
 Given("a location", async function (): Promise<void> {
   this.context.location = Location.create(48.8566, 2.3522);
@@ -71,9 +71,7 @@ Then(
     const expected = new VehicleAlreadyParkedAtThisLocationError(
       this.context.vehicle.plateNumber,
       this.context.fleetId,
-      this.context.location.latitude,
-      this.context.location.longitude,
-      this.context.location.altitude,
+      this.context.location,
     );
 
     expect(this.context.parkingAttemptError).to.deep.equal(expected);

features/steps/park_vehicle_steps.ts

@@ -4,17 +4,17 @@ import { World } from "cucumber";
 import { expect } from "chai";
 
 // Second group: Domain
-import { User } from "../../src/Domain/Models/User.js";
-import { Vehicle } from "../../src/Domain/Models/Vehicle.js";
-import { VehicleAlreadyRegisteredError } from "../../src/Domain/Errors/VehicleAlreadyRegisteredError.js";
+import { User } from "../../src/Domain/Models/User";
+import { Vehicle } from "../../src/Domain/Models/Vehicle";
+import { VehicleAlreadyRegisteredError } from "../../src/Domain/Errors/VehicleAlreadyRegisteredError";
 
 // Third group: Helpers
-import { initializeFleetForUser } from "./shared/initializeFleetForUser.js";
-import { retrieveFleet } from "./shared/retrieveFleet.js";
+import { initializeFleetForUser } from "./shared/initializeFleetForUser";
+import { retrieveFleet } from "./shared/retrieveFleet";
 import {
   RegisterVehicle,
   RegisterVehicleHandler,
-} from "../../src/App/Commands/registerVehicle.js";
+} from "../../src/App/Commands/registerVehicle";
 
 Given("the fleet of another user", async function (): Promise<void> {
   this.context.otherUser = User.create(crypto.randomUUID());

features/steps/register_vehicle_steps.ts

@@ -1,9 +1,9 @@
-import { FleetRepository } from "../../../src/Domain/Repositories/FleetRepository.js";
-import { User } from "../../../src/Domain/Models/User.js";
+import { FleetRepository } from "../../../src/Domain/Ports/FleetRepository";
 import {
   InitializeFleet,
   InitializeFleetHandler,
-} from "../../../src/App/Commands/initializeFleet.js";
+} from "../../../src/App/Commands/initializeFleet";
+import { User } from "../../../src/Domain/Models/User";
 
 export async function initializeFleetForUser(
   repository: FleetRepository,

features/steps/shared/initializeFleetForUser.ts

@@ -1,9 +1,9 @@
-import { Location } from "../../../src/Domain/Models/Location.js";
-import { FleetRepository } from "../../../src/Domain/Repositories/FleetRepository.js";
+import { Location } from "../../../src/Domain/Models/Location";
+import { FleetRepository } from "../../../src/Domain/Ports/FleetRepository";
 import {
   ParkVehicle,
   ParkVehicleHandler,
-} from "../../../src/App/Commands/parkVehicle.js";
+} from "../../../src/App/Commands/parkVehicle";
 
 export async function parkVehicleAtLocation(
   repository: FleetRepository,

features/steps/shared/parkVehicleAtLocation.ts

@@ -1,9 +1,6 @@
-import { Fleet } from "../../../src/Domain/Models/Fleet.js";
-import { FleetRepository } from "../../../src/Domain/Repositories/FleetRepository.js";
-import {
-  GetFleet,
-  GetFleetHandler,
-} from "../../../src/App/Queries/getFleet.js";
+import { Fleet } from "../../../src/Domain/Models/Fleet";
+import { FleetRepository } from "../../../src/Domain/Ports/FleetRepository";
+import { GetFleet, GetFleetHandler } from "../../../src/App/Queries/getFleet";
 
 export async function retrieveFleet(
   repository: FleetRepository,